-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats function moved to be better shared across metrics #1014
Conversation
Add more for stats branch
@acordonez Below functions can be imported from
|
@lee1043 Thanks for the links. It looks like these are getting implemented in the mean climate metrics - would it also be helpful for me to run those notebooks for a test? |
@acordonez statistical computation functions were relocated to under stats directory from under mean_climate directory. Sorry for mixing two different subjects in one PR. Yes, checking mean_climate notebook would be very helpful, thank you for suggesting it! |
@lee1043 This comment probably doesn't matter for regular lat/lon grids, if that's what we're targeting. With the sea ice data, I'm still having some struggles with the get_latitude_key() and get_longitude_key() functions. For the dataset shown below, they'll return the 'i' and 'j' variables, which are not technically latitude and longitude even though they are the X and Y axis coordinates. |
@lee1043 For the rest of the functions, they are working as expected. I also ran the mean climate notebook and the results look similar to past runs. |
@acordonez thank you for checking this. I think I would merge this PR first and handle the sea-ice data issue in separate. Would you approve the PR if you are okay with that? If you could open an issue and point to me the example dataset (if that is different to one used previously -- I think the other one had ni and nj, so this might be a different one?) that would be greatly helpful. |
This PR will address #1012
In addition, io functions for xcat-based xarray dataset were added via this PR. These functions can be imported by something like below: