Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo 9b sea-ice data explore notebook update #1054

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Demo 9b sea-ice data explore notebook update #1054

merged 8 commits into from
Feb 9, 2024

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Feb 9, 2024

  • Added more data plot for visualizing time evolution
  • Added table of contents to the notebook

@lee1043 lee1043 added the demo label Feb 9, 2024
@lee1043 lee1043 requested review from durack1 and acordonez February 9, 2024 19:01
@lee1043 lee1043 self-assigned this Feb 9, 2024
Copy link
Collaborator

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lee1043 nice update - I particularly like that you have embedded section links in the table of contents, I hadn't figured out how to do that, but it's definitely useful. One addition could be to add a "table of contents" link at each section, so you can jump from halfway through to the top, and back down as you like, it's a looooong notebook (same with the demo when considering the output)

@durack1
Copy link
Collaborator

durack1 commented Feb 9, 2024

@lee1043 looks like this works for me https://nbviewer.org/github/PCMDI/pcmdi_metrics/blob/lee1043-patch-1/doc/jupyter/Demo/Demo_9b_seaIce_data_explore.ipynb#tmse. I presume this also works for the binder jupyterhub examples?

Copy link
Collaborator

@acordonez acordonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran all cells in BinderHub. I also tried out all the links to make sure they work!

@lee1043
Copy link
Contributor Author

lee1043 commented Feb 9, 2024

@durack1 great suggestion. I added links to to top. This works best for nbviewer (I added that note in the notebook as well), but I am not sure for binder-hub. If you can give a try, let me know if that works.

@acordonez thank you for checking the links. Can you help applying similar update to Demo9?

@lee1043 lee1043 merged commit 84ad62c into main Feb 9, 2024
5 checks passed
@lee1043 lee1043 deleted the lee1043-patch-1 branch February 9, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants