Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the parallel coordinate plot code #1075

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Mar 27, 2024

  • Added parameters to enable label for violin plot in legend and to allow more of customization of the legend box
  • Minor clean up for less print on screen
  • Regenerated example plots using the latest code and data

@lee1043 lee1043 self-assigned this Mar 27, 2024
@lee1043 lee1043 requested a review from kristinchang3 March 27, 2024 21:15
Copy link
Collaborator

@kristinchang3 kristinchang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jiwoo,

This looks great! The only error I ran into was for adding the watermark to any example images: rotation was set to a string of '25' instead of an integer 25. I went ahead and removed the quotations. Otherwise, these look great!

@lee1043
Copy link
Contributor Author

lee1043 commented Apr 23, 2024

@kristinchang3 thanks! I am merging the PR.

@lee1043 lee1043 merged commit 2026ee0 into main Apr 23, 2024
5 checks passed
@lee1043 lee1043 deleted the lee1043-parallel-coord-plot-improve branch April 23, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants