Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data files and model mask to sea ice metrics #1082

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Conversation

acordonez
Copy link
Collaborator

@acordonez acordonez commented Apr 25, 2024

This PR accomplishes four things:

  1. Adds a data file to the output bundle that includes the time mean sea ice and climatology.
  2. Fixes a bug where the land sea mask was not applied to models.
  3. Reports the MSE for the climatology without the mean included
  4. Changes the y-axis settings on the output figure

@acordonez acordonez requested review from gleckler1 and lee1043 April 25, 2024 16:15
@acordonez acordonez changed the title Add data files and model mask Add data files and model mask to sea ice metrics Apr 25, 2024
@lee1043
Copy link
Contributor

lee1043 commented Apr 25, 2024

@acordonez thanks for the PR, I am running demo 9 notebook with this PR.

@lee1043
Copy link
Contributor

lee1043 commented Apr 25, 2024

@acordonez I checked the demo 9 notebook runs without error. But considering the graphics changed with the PR, could you please also update the notebook? Or I can also help update, let me know.

@acordonez
Copy link
Collaborator Author

@lee1043 Yes I can rerun the notebook.

@acordonez
Copy link
Collaborator Author

@lee1043 I pushed the notebook

@acordonez acordonez merged commit f1d1542 into main Apr 25, 2024
5 checks passed
@acordonez acordonez deleted the ao_sea_ice_add_data branch April 25, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants