Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NaN in sea ice clims #1096

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Handle NaN in sea ice clims #1096

merged 8 commits into from
Jun 4, 2024

Conversation

acordonez
Copy link
Collaborator

@acordonez acordonez commented May 8, 2024

The model mean metrics calculation is changed so that NaNs from an individual realization are not considered. I've tested this change locally with multiple models.
This also contains a fix to pick the most recent dated version when a wildcard is used for the version when running over many CMIP6 models.

@acordonez acordonez marked this pull request as ready for review May 16, 2024 23:33
@acordonez acordonez requested a review from lee1043 May 16, 2024 23:50
@acordonez
Copy link
Collaborator Author

@lee1043 If you run the Jupyter notebook the data results should remain the same (it's possible there have been some changes to the figure scales since we last ran the notebooks, but the actual metrics shouldn't change).

@acordonez acordonez self-assigned this Jun 3, 2024
Copy link
Contributor

@lee1043 lee1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR!

@acordonez acordonez merged commit d2d7f4e into main Jun 4, 2024
5 checks passed
@acordonez acordonez deleted the ao_seaice_real branch June 4, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants