Compiling error for gcc < 5.1

[arnfinn]

The flags ‘-Wsuggest-final-types’, ‘-Wsuggest-final-methods’ and ‘-Wsuggest-override’ introduced in gcc 5.1, but used also for gcc < 5.1

Expected Behavior

No error

Current Behavior

Error during compiling:
g++: error: unrecognized command line option ‘-Wsuggest-final-types’
g++: error: unrecognized command line option ‘-Wsuggest-final-methods’
g++: error: unrecognized command line option ‘-Wsuggest-override’

Possible Solution

if(CXX_COMPILER_VERSION VERSION_LESS 5.1.0 OR NOT ENABLE_CXX11_SUPPORT)

Steps to Reproduce (for bugs)

On Stallo

1. module load GCCcore/4.9.3
2. ./setup
3. cd build
4. make

[bast]

And I assume that the project supports GCC < 5.1. If we take .travis-ci.yml as reference, then yes.

[robertodr]

Yes, confirmed as a bug. Apologies for being late on this 😄

[bast]

My goal is to do something like this: http://stackoverflow.com/a/4065761. Better ideas?

[robertodr]

That would be a better solution to get the version number. Eventually I wanted to move to a scheme were flags are checked for compatibility with the compiler before being set. I have a semi-working version here

[bast]

OK so I will go with the version number first and later we can switch to your scheme. I think I like it.

[robertodr]

I think it should be safer and should lead to cleaner CMake code. On the other hand, I can't quite decide if compiler flags should be set globally or on a per-target basis.

[bast]

For me globally (when the globe is the library) if possible, and per target if needed.

[robertodr]

I would then remove the summary.cmake from here since the information is possibly unreliable.

[bast]

What is the target branch for a fix?

[robertodr]

release/1.Y I would then update master by cherry-picking.

[bast]

OK let me know if it went to the wrong branch, I can easily relocate.