FIx handling of pcmsolver.f90 file #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## release/1.2.Z #143 +/- ##
==============================================
Coverage 69.81% 69.81%
==============================================
Files 92 92
Lines 5625 5625
==============================================
Hits 3927 3927
Misses 1698 1698
Continue to review full report at Codecov.
|
|
I think this is how it should be done :-) |
arnfinn
reviewed
Apr 10, 2018
cmake/custom/api.cmake
Outdated
| # | ||
| # docopt: "--fbindings=<ENABLE_Fortran_API> Enable compilation of Fortran 90 API bindings <ON/OFF> [default: ON]." | ||
| # define: "'-DENABLE_Fortran_API={0}'.format(arguments['--fbindings'])" | ||
| # docopt: "--fbindings=<TEST_Fortran_API> Enable compilation of Fortran 90 API bindings <ON/OFF> [default: ON]." |
There was a problem hiding this comment.
Change to Test the Fortran 90 bindings for the API.?
cmake/custom/api.cmake
Outdated
| # define: "'-DTEST_Fortran_API={0}'.format(arguments['--fbindings'])" | ||
|
|
||
| option(ENABLE_Fortran_API "Enable compilation of Fortran 90 API bindings" ON) | ||
| option(TEST_Fortran_API "Enable compilation of Fortran 90 API bindings" ON) |
There was a problem hiding this comment.
Change to Test the Fortran 90 bindings for the API.?
setup.py
Outdated
| --omp Enable OpenMP parallelization [default: False]. | ||
| --python=<PYTHON_INTERPRETER> The Python interpreter (development version) to use. [default: '']. | ||
| --fbindings=<ENABLE_Fortran_API> Enable compilation of Fortran 90 API bindings <ON/OFF> [default: ON]. | ||
| --fbindings=<TEST_Fortran_API> Enable compilation of Fortran 90 API bindings <ON/OFF> [default: ON]. |
There was a problem hiding this comment.
Change to Test the Fortran 90 bindings for the API.?
arnfinn
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix spurred by writing the IJQC paper:
pcmsolver.f90is now installed alongside the headers. It is the responsibility of the host code to optionally compile it and link against PCMSolver.Types of changes
Status