Fix API for the surface function NumPy save/load functions #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnfinn
approved these changes
Apr 11, 2017
ilfreddy
approved these changes
Apr 21, 2017
|
You don't mind the merge commits there? If not, then I can press the green button. |
|
@bast please squash the merge commits. Thanks! |
|
You mean all 4 commits into 1 (this is easy) - or commits 3 and 4 into 2? The latter would require me to file a PR to you fixing this which would update this PR. |
|
I would save only the first two commits. Are you sure you can't squash at
will with the web UI?
|
|
There is a button that says that 4 commits will be squashed into one. I am not sure there is more fine-grain after that button. Doubt it but of course I will be glad to be proven wrong. |
Some surface function save/load API functions declared the passed strings with the wrong data type: character(c_char), intent(in) :: name instead of: character(c_char), intent(in) :: name(*) (cherry picked from commit 7fc97c7384fb90f1266e59a70036667ab4fb60f6)
This commit also adds calls to the API functions pcmsolver_save_surface_functions, pcmsolver_save_surface_function and pcmsolver_load_surface_function in the C_host and Fortran_host executables. This makes sure that these functions get exercised and provide a test against trivial API breakages.
robertodr
force-pushed
the
fix-fortran-api
branch
from
a99c9cd to
bdb2783
Compare
|
I rebased wrt |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Fortran API for the surface function NumPy save/load functions and adds calls to these functions in the C and Fortran host example executables.
These calls are just to exercise these functions and protect against "basic" API breakages, thus fixing #70
A bug (dormant) was also fixed in the C++ API: the save function was writing the NumPy array file with the incorrect dimension information, subsequently causing the load function to crash.
Todos
Types of changes
Status