test: avoid Undefined Behaviour because of NULL pointer arithmetic in test17 #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 4ef0c51 (Interpret NULL pointer, zero length as an empty string for subjects and replacements., 2021-11-30), a NULL pointer with zero length has been internally replaced with an empty string in all matching functions, but the test for jit was incorrectly using the fastpath which intentionally skips all validation and results in NULL pointer arithmetic operations. Change the test to use the validating jit path instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a regression, as it seems to be included with the 10.40 release.
Resolves the following error when building with UBSAN in a recent compiler: