Implement vreverse in jit #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was no need to cut out JIT for vreverse tests because of the automatic fallback to the interpreter. The cut out tests are for the changes to \w and [:xdigit:]. I will merge and run tests on this patch shortly. That then leaves only the \w and [:xdigit:] changes that need an update to JIT. |
|
As you were. I see that this patch also contains the updates for \w and [:xdigit:]. Thanks. |
|
I am thinking about optimizing the ucp support further. Btw I added the support here because I got all kinds of assertion failures in debug without them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started working on vreverse. Unfortunately the task is very hard, because it adds another layer to the already complex bracket/assertion matching. Each new layer kind of duplicates the complexity, so I have no idea how many bugs I introduce with this patch. To tell the truth it was a long time ago when I developed the original code, and forgot many things since then.
The tests are passing now, although @PhilipHazel mentioned the vreverse tests are disabled for jit. I didn't see anything which disables them. Is there something I miss?
The patch also contains some unicode fixes, they can be moved to another patch if needed.