Add AM_MAINTAINER_MODE for users checking out a release tag #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
added a commit
that referenced
this pull request
Feb 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received the suggestion to use a (signed) Git tag for the 10.45 release. This lets users fetch releases with Git rather than manually downloading, unpacking, and verifying a tarball.
When testing this, I realised there was a problem with the Autoconf setup. The release tag should have the
./configurescript checked in (so that the tag matches the tarball), but, a Git tag is checked out with totally random mtimes set on the files (whereas a tarball unpacks with mtimes preserved). This leads to the./configurescript being regenerated, which is a different behaviour.The fix is to disable automake's "maintainer mode" on release branches.
For discussion, see for example libexpat/libexpat#726, or https://autotools.info/automake/maintainer.html.