Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSDX-TC] Regression in Jackie Chan Adventures #1838

Closed
ssakash opened this issue Feb 24, 2017 · 6 comments · Fixed by #2382
Closed

[GSDX-TC] Regression in Jackie Chan Adventures #1838

ssakash opened this issue Feb 24, 2017 · 6 comments · Fixed by #2382
Assignees
@gregory38
Labels
GS: Texture Cache GS Regression

Comments

@ssakash
Copy link
Member

ssakash commented Feb 24, 2017

Jackie Chan Adventures doesn't seem to like the skip of drawcall (87fc4c1) in #1760 , reverting that and adding back return LookupSource(TEX0, TEXA, r); seems to fix the half screen flickering issue in Jackie Chan Adventures. FYI, this game also enters the half right path which is there for the Snowblind games.

Before #1760:

before

After #1760:

after

GSDump: here
@ssakash ssakash added this to the Release 1.6 milestone Feb 24, 2017
@ssakash ssakash mentioned this issue Feb 24, 2017
Merged
@FlatOutPS2
Copy link
Contributor

FYI, this game also enters the half right path which is there for the Snowblind games.

What happens if you block it?

@ssakash
Copy link
Member Author

ssakash commented Feb 24, 2017

What happens if you block it?

Issue still exists even if you block the special case for Snowblind games. (I just mentioned about the half_right code path in case it might be useful)

@gregory38
Copy link
Contributor

Hum, it could just require to handle the half case when we lookup the depth. I won't touch it now as I would like a more generic solution.

@gregory38
Copy link
Contributor

@ssakash @FlatOutPS2 What about a crc hack with a big comment message to explain the situation.

This was referenced Mar 11, 2017
Closed
Closed
gregory38 added a commit that referenced this issue Mar 17, 2017
@gregory38
gsdx tc: revert 87fc4c1
0ec4bbe 
At least 2 regressions
* SVC Chaos #1862
* Jackie Chan #1838

I don't see any difference on Full Spectrum Warrior gsdump (#1757). Both return
and throw flicker. And none has the original vertical line issue. I suspect
it is linked to the behavior of depth miss.

The correct fix would be to trace all textures writes to be sure of the source.
But it is a much bigger work.
@gregory38 gregory38 mentioned this issue Mar 17, 2017
Closed
3 tasks
@MrCK1 MrCK1 mentioned this issue Jun 2, 2017
Closed
@MrCK1 MrCK1 mentioned this issue Jan 1, 2018
Closed
@lightningterror lightningterror mentioned this issue Apr 13, 2018
Merged
@lightningterror
Copy link
Contributor

lightningterror commented Apr 25, 2018 •
edited
Loading

There still seems to be some issues to iron out on D3D. The language select background is black instead of yellow.

Regression PR #1776

@lightningterror lightningterror mentioned this issue Apr 25, 2018
Closed
@lightningterror lightningterror removed this from the Release 1.6 milestone May 6, 2018
@lightningterror lightningterror mentioned this issue May 27, 2018
Closed
8 tasks
@lightningterror
Copy link
Contributor

Fixed on d3d11.

@lightningterror lightningterror mentioned this issue Feb 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregory38 gregory38

Labels
GS: Texture Cache GS Regression
Projects
None yet
Milestone
No milestone
4 participants
@gregory38 @ssakash @FlatOutPS2 @lightningterror