Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDL Demos: simple demos to prepare sound (sine waves) with PDL #426

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

HaraldJoerg
Copy link
Contributor

The demo uses PDL to calculate the samples of sine waves in one line, and then passes the "raw" PDL data to an external sound player.

I don't know whether this is good enough for a demo, but for me it was enlightening to see that raw sound can be calculated without looping over Perl arrays, and then directly passed to a sound player.

Since this is my first step with PDL, I'd welcome a review anyway. I might easily have misunderstood things.

@mohawk2
Copy link
Member

mohawk2 commented Apr 14, 2023

Thank you for this! How do you feel about looking at Alien::Gnuplot and copying it to make an installer for a Linux/Windows/MacOS-capable sound player?

@zmughal What do you think? Do you have capacity to help Harald?

@coveralls
Copy link

coveralls commented Apr 14, 2023

Coverage Status

Coverage: 32.491% (+0.007%) from 32.484% when pulling 2a04a34 on HaraldJoerg:sound-demo into 4f42076 on PDLPorters:master.

@mohawk2
Copy link
Member

mohawk2 commented Apr 14, 2023

@HaraldJoerg Thank you for your continuing work on this! Please could you not merge master into your branch, but instead switch to your master, pull that, then rebase your demo branch against that, then force-push?

@HaraldJoerg
Copy link
Contributor Author

Ouch... merging the master branch was not intended at all... My bad handling of the GitHub is to blame.

About creating an Alien module for a player: I feel that the added value is too small if it is just for running a demo. I am still unsure where my experiments with sound will float to. PDL ndarrays are not too far away from Microsoft WAV files which can be played on any platform because they contain the necessary metadata...

The demo uses PDL to calculate the samples of sine waves in one line,
and then passes the "raw" PDL data to an external sound player.
@mohawk2 mohawk2 merged commit c755f50 into PDLPorters:master Apr 18, 2023
@HaraldJoerg HaraldJoerg deleted the sound-demo branch April 18, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants