-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add propagation of badflag with .= (Ops::assgn) for sf.net bug 3543056. #51
Conversation
I believe this needs to only run when |
We'll be able to tell more easily once #18 is merged and we rebase against it. |
e5b7a5d
to
824bc6e
Compare
Temporary close because Travis fouls up with race condition when both branch and PR. |
0a29cb6
to
6f8d393
Compare
LIke I was saying in IRC http://irclog.perlgeek.de/pdl/2015-03-03#i_10215431, this won't fix the code until the |
2f47a52
to
6b24622
Compare
@hainest, what are your thoughts on the readiness state of this? Does work remain to be done? |
I think that as long as folks are content with the lack of child->parent bad flag propagation, then this can be pulled into master. The (admittedly verbose) idiom for ensuring bad flag propagation is provided in the comments of assign. |
I think merging should wait until post 2.008, which is imminent. However, there is talk of a much faster release cycle after that, so that'll help. May I suggest changing the location of telling people the correct idiom move from comments, to actual documentation? Feel like making a PR onto this branch? I'll then bring it across and we can see how it plays. |
I misspoke. The description is in the Doc field, so it should be rendered to the documentation automatically.
I thought it was already pulled. Github says that I can merge the PR, but I'm not sure how that aligns with the rebase procedure. |
It means this branch, as rebased by me, can be merged. It doesn't mean you can do so, until you get a commit bit on the appropriate repo (of which this is a mirror). If you make your fork be up to date with this repo, then branch off this branch, then PR onto this branch (or against master, I'll figure it out), then you can submit changes to your code here. That is what I am saying you could do, if you feel it useful. |
efaeee7
to
22d290a
Compare
22d290a
to
1437cd8
Compare
Rebased to update for |
@hainest @d-lamb @devel-chm @zmughal @drzowie Is this ready for primetime? :-) |
@mohawk2 I think so. I would reiterate my previous comment:
|
Limitations are documented. Tests are passing. Merging. |
The above-linked commit actually now means |
Rebased version of #2. Passes tests.