Cleanup #167
Merged
Cleanup #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
========================================
Coverage 71.21% 71.21%
========================================
Files 12 12
Lines 1181 1181
Branches 272 272
========================================
Hits 841 841
Misses 290 290
Partials 50 50
Continue to review full report at Codecov.
|
yannikschaelte
approved these changes
Dec 4, 2019
| @@ -1,7 +1,6 @@ | |||
| import numpy as np | |||
| import pandas as pd | |||
| import petab | |||
There was a problem hiding this comment.
alphabetic ordering + own tools / petab last? very in favor.
There was a problem hiding this comment.
yeah
pycharm does the job for you (code -> optimize imports)
| @@ -239,7 +241,7 @@ def assert_parameter_estimate_is_boolean(parameter_df): | |||
| 0 or 1. | |||
| """ | |||
| for estimate in parameter_df['estimate']: | |||
| if not int(estimate) in [True, False]: | |||
| if int(estimate) not in [True, False]: | |||
| for i in range(len(unique_noise)): | ||
| for j in range(len(unique_sc)): | ||
| # Find the position of all instances of unique_noise[i] | ||
| for i_noise, cur_noise in enumerate(unique_noise): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring code quality back to A.