Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use entrypoints to install petablint as a command #85

Merged
merged 4 commits into from
Mar 20, 2019

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Mar 20, 2019

  • Added missing requirement "colorama"
  • Update README.md accordingly
  • Move /bin/petablint.py into main module and add Python entrypoint

Now it's possible to call petablint like any other unix command (e.g., grep, cat, etc.). Python automatically takes care of this when pip installing.

@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #85 into develop will decrease coverage by 5.43%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
- Coverage    59.17%   53.74%   -5.44%     
===========================================
  Files            5        6       +1     
  Lines          632      694      +62     
  Branches       136      147      +11     
===========================================
- Hits           374      373       -1     
- Misses         230      293      +63     
  Partials        28       28
Impacted Files Coverage Δ
petab/petablint.py 0% <0%> (ø)
petab/core.py 70.96% <20%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f17ac...5c127f9. Read the comment docs.

Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

Could you change the target to ICB-DCM:develop instead of master (following a develop/master branching structure)?

@cthoyt cthoyt changed the base branch from master to develop March 20, 2019 09:43
@cthoyt
Copy link
Contributor Author

cthoyt commented Mar 20, 2019

@yannikschaelte good call! I didn't realize that you had the develop/master dichotomy. Perhaps it might be helpful for new developers to make the develop branch the default one.

I've merged the changes from develop into this branch then pointed the merge to the develop branch. Looks like one of the changes (adding the colorama requirement) had even already been fixed!

@yannikschaelte yannikschaelte merged commit 874ac53 into PEtab-dev:develop Mar 20, 2019
@cthoyt cthoyt deleted the add-entrypoints branch March 20, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants