Introduce Monostable filters #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to have failed since electroids repo is down |
Pablete1234
requested changes
Jan 11, 2022
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/filters/modifier/QueryModifier.java
Outdated
Show resolved
Hide resolved
KingOfSquares
force-pushed
the
dynamic-time-filter
branch
from
87a939d
to
3201926
Compare
|
Ive drafted changes based on the feedback. I have yet to test these changes, so don't merge them yet 🙃 |
Pablete1234
requested changes
Jan 19, 2022
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
|
Currently waiting for #964 |
KingOfSquares
force-pushed
the
dynamic-time-filter
branch
2 times, most recently
from
ea834bc
to
810afbb
Compare
Pablete1234
requested changes
Apr 21, 2022
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
|
I've pushed the response to code review for initial review again, but the code is not yet tested on a server |
|
Ok code has been tested an the changes seem to work as expected |
Pablete1234
reviewed
Apr 21, 2022
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
KingOfSquares
force-pushed
the
dynamic-time-filter
branch
from
6eb8cd4
to
9c7734b
Compare
Pablete1234
previously approved these changes
Apr 22, 2022
Pablete1234
reviewed
May 12, 2022
core/src/main/java/tc/oc/pgm/filters/dynamic/FilterMatchModule.java
Outdated
Show resolved
Hide resolved
Pablete1234
reviewed
May 12, 2022
KingOfSquares
force-pushed
the
dynamic-time-filter
branch
from
9c7734b
to
e79c879
Compare
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> format :( Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Feedback changes Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Changes from feedback and draft for PGMDev#964 Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Move null check Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> finish initial implementation Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> javadoc changes Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> format Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> review feedback Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> more review feedback Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
KingOfSquares
force-pushed
the
dynamic-time-filter
branch
from
e79c879
to
14c2f65
Compare
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
KingOfSquares
force-pushed
the
dynamic-time-filter
branch
from
14c2f65
to
0c6adfc
Compare
Pablete1234
approved these changes
Jun 17, 2022
Electroid
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for time period based filters.
This PR also makes the existing time filter dynamic.
I would like feedback on the design, old PGM used the filter definitions as
FeatureFactorys to create theReactorinstances, but that is not ideal for this PGM because it does not use injection.Signed-off-by: KingSimon 19822231+KingOfSquares@users.noreply.github.com