Refactor FeatureDefinitionContext to extend ContextStore #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingOfSquares
force-pushed
the
context-store
branch
from
26b8d84
to
89ea365
Compare
Pugzy
reviewed
Feb 3, 2022
core/src/main/java/tc/oc/pgm/controlpoint/ControlPointModule.java
Outdated
Show resolved
Hide resolved
KingOfSquares
force-pushed
the
context-store
branch
from
8a26d02
to
97afd8d
Compare
KingOfSquares
added a commit
to KingOfSquares/PGM
that referenced
this pull request
Feb 7, 2022
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
KingOfSquares
force-pushed
the
context-store
branch
from
97afd8d
to
5a2b24b
Compare
|
In an attempt to move this faster the PR has been slimmed down drastically to only include necessary changes for the code to work |
Pablete1234
approved these changes
Apr 12, 2022
KingOfSquares
added a commit
to KingOfSquares/PGM
that referenced
this pull request
Apr 18, 2022
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
KingOfSquares
added a commit
to KingOfSquares/PGM
that referenced
this pull request
Apr 18, 2022
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
KingOfSquares
added a commit
to KingOfSquares/PGM
that referenced
this pull request
Apr 22, 2022
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
KingOfSquares
added a commit
to KingOfSquares/PGM
that referenced
this pull request
May 19, 2022
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> format :( Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Feedback changes Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Changes from feedback and draft for PGMDev#964 Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Move null check Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> finish initial implementation Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> javadoc changes Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> format Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> review feedback Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> more review feedback Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
KingOfSquares
added a commit
to KingOfSquares/PGM
that referenced
this pull request
Jun 17, 2022
Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> format :( Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Feedback changes Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Changes from feedback and draft for PGMDev#964 Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> Move null check Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> finish initial implementation Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> javadoc changes Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> format Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> review feedback Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com> more review feedback Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for finalizing #950 I decided to split out this part into its own PR.
The idea behind the change is to be able to depend on the general
ContextStorein places where you need someFeatureDefinitionthat may be in its own context on legacy maps(proto 1.3), e.gFilterContextor in the generalFeatureDefinitionContexton newer maps(1.4 proto). Then the correct context can be passed without having to instance check for different types of contexts or other hackery.I also decided to update naming in the
ContextStore, as it is now used in newer protos whereidis the proper term.(in contrast toname)Also other small changes...
Note: The
Mapused to store feature definitions is now aTreeMap(Same asContextStorehas been using until now), which technically could reduce performance but its so small that I think its negligible.