-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Fix type error when using paths intersection mode #6734
Merged
keradus
merged 2 commits into
PHP-CS-Fixer:master
from
julienfalque:fix-intersection-path-error
Jan 2, 2023
Merged
bug: Fix type error when using paths intersection mode #6734
keradus
merged 2 commits into
PHP-CS-Fixer:master
from
julienfalque:fix-intersection-path-error
Jan 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3825623956
💛 - Coveralls |
julienfalque
force-pushed
the
fix-intersection-path-error
branch
from
January 2, 2023 18:35
9a8fb76
to
21422f1
Compare
keradus
reviewed
Jan 2, 2023
@@ -93,7 +106,7 @@ private function getDefaultArguments(): array | |||
return [ | |||
'path' => [__FILE__], | |||
'--path-mode' => 'override', | |||
'--allow-risky' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
keradus
reviewed
Jan 2, 2023
keradus
reviewed
Jan 2, 2023
@@ -29,6 +30,19 @@ | |||
*/ | |||
final class FixCommandTest extends TestCase | |||
{ | |||
public function testIntersectionPathMode(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome to have the test for this!
keradus
approved these changes
Jan 2, 2023
Closed
kudos @julienfalque ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6718 and replaces #6719.