Skip to content

Test to make sure container can set and resolve interface - issue 641 #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2018
Merged

Test to make sure container can set and resolve interface - issue 641 #621

merged 2 commits into from
Aug 31, 2018

Conversation

smytsyk
Copy link

@smytsyk smytsyk commented Aug 31, 2018

DI\get was able to resolve binding on interface in PHP-DI 5, however it's not working on v6 anymore.

#614

@smytsyk smytsyk mentioned this pull request Aug 31, 2018
Closed
@mnapoli mnapoli mentioned this pull request Aug 31, 2018
Merged
@mnapoli
Copy link
Member

mnapoli commented Aug 31, 2018

Thanks, I've opened #622 with a fix.

@mnapoli mnapoli added the bug label Aug 31, 2018
@mnapoli mnapoli merged commit d91bd65 into PHP-DI:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smytsyk @mnapoli