Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic/SpaceAfterNot: improve code coverage #489

Merged

Conversation

rodrigoprimo
Copy link
Contributor

Description

This PR improves code coverage for the Generic.Formatting.SpaceAfterNot sniff.

Related issues/external references

Part of #146

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Doing this to be able to create tests with syntax errors on separate
files.
@jrfnl jrfnl added this to the 3.10.0 milestone May 15, 2024
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodrigoprimo !

@jrfnl
Copy link
Member

jrfnl commented May 15, 2024

Rebased without changes. Merging once the build passes.

@jrfnl jrfnl force-pushed the test-coverage-space-after-not branch from 7ebdd66 to 3404ca3 Compare May 15, 2024 19:24
@jrfnl jrfnl merged commit 35b306c into PHPCSStandards:master May 15, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants