Magic methods being picked up by function regex pattern

[jbrooksuk]

This issue is being raised on __construct:

Function __construct name should follow the pattern /^[a-z_][a-zA-Z0-9]$/.

The __construct method and any other magic methods should be exempt from this. Do you agree @tchule?

[tchule]

Agree, it's a bug. I will try to have a look today if I can.

[jbrooksuk]

I think we should create a configuration file for PSR standards too. Some of these mean that private methods have a different naming pattern.

[tchule]

Yes i listed that as "task 68" on my side but never took the time to do it.

[jbrooksuk]

I end up converting them to YAML, so if you do it before I do, let me know and I'll convert it for Anorak.

[tchule]

Do you have a test case for the constructor problem ? I haven't been able to reproduce it.

[jbrooksuk]

Try this (there will be other errors, but I'm aware of them).

<?php 

    /**
     * CommitFile
     * Every file in a Commit is wrapped in this.
     *
     * @author James Brooks <jbrooksuk@me.com>
     */
    class CommitFile {
        protected $File;
        protected $Commit;

        public function __construct($File, $Commit) {
            $this->File = $File;
            $this->Commit = $Commit;
        }

        public function sha() {
            return $this->File['sha'];
        }

        public function filename() {
            return $this->File['filename'];
        }

        public function content() {
            if(!$this->removed()) {
                return $this->Commit->fileContent($this->filename());
            }else{
                return FALSE;
            }
        }

        public function removed() {
            return $this->File['status'] === 'removed';
        }

        public function modifiedLines() {
            return $this->patch()->additions();
        }

        public function modifiedLineAt($lineNumber) {
            return array_map(function($modifiedLine) {
                return $modifiedLine->lineNumber === (int)$lineNumber;
            }, $this->modifiedLines());
        }

        private function patch() {
            return new Patch($this->File['patch']);
        }
    }

[tchule]

OK, but i don't have the warning.

If the "constructorNaming" rule is set to "old", I have this message : "The constructor name must be CommitFile".

If the "constructorNaming" rule is set to "new", I have no warning. The function is detected as being the constructor and is not checked for naming rules.

What is your config file ?

[jbrooksuk]

Interesting.

My configuration file is all in YAML, so I'm going to make sure that I've converted them properly. I'll add you to the Anorak repository so you can see the status of the issue.

[tchule]

ok, i'll follow that ^^

[jbrooksuk]

I think I've figured this out. My configuration file may have been wrong. I've just gone through and ensured it's right. When I've got a Pull Request to go on, I'll let you know.

[jbrooksuk]

Bad configuration file caused this.