Constants/NewMagicClassConstant: bug fix #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on #1500 which added a test for the use of `::class` within an attribute. At the time, this was set to be flagged. However, as attributes are interpreted as comments on PHP < 8.0, using `::class` within an attribute is not actually problematic. Fixed now.
jrfnl
added
bug
PR: quick merge
wimg
approved these changes
Mar 31, 2024
github-actions
bot
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1500 which added a test for the use of
::classwithin an attribute.At the time, this was set to be flagged. However, as attributes are interpreted as comments on PHP < 8.0, using
::classwithin an attribute is not actually problematic.Fixed now.