Skip to content

Issue/26 lowercase input keys #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2016
Merged

Issue/26 lowercase input keys #27

merged 2 commits into from
Dec 30, 2016

Conversation

Miljar
Copy link
Contributor

@Miljar Miljar commented Dec 30, 2016

Fixes #26

@Miljar
Normalize input data keys
8639cbc 
Different vendors can use different names for the EXIF tags.
E.g: "Copyright" or "CopyRight"; "Software" or "SoftWare".

Normalizing the keys of the input data prevents issues where the input
data is available, but cannot be found due to casing differences.

Signed-off-by: Tom Van Herreweghe <tom@theanalogguy.be>
@Miljar
Cleanup unused ResolutionFieldMapper::$map property
99b9072 
Signed-off-by: Tom Van Herreweghe <tom@theanalogguy.be>
@coveralls
Copy link

coveralls commented Dec 30, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 98.876% when pulling 99b9072 on Miljar:issue/26-lowercase-input-keys into 672b15f on PHPExif:develop.

@Miljar Miljar merged commit d128c2b into PHPExif:develop Dec 30, 2016
@Miljar Miljar deleted the issue/26-lowercase-input-keys branch December 30, 2016 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Miljar @coveralls