Skip to content

Update unit tests in preparation for PHP 7.2 compatibility #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2018
Merged

Update unit tests in preparation for PHP 7.2 compatibility #71

merged 3 commits into from
Mar 30, 2018

Conversation

martin-georgiev
Copy link
Contributor

This MR modernises the unit tests so they no longer use the deprecated getMock method.
This paves the way for PHPUnit to be upgraded, something that's very much needed for enabling PHP 7.2 CI support.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 261

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 98.462%
Totals Coverage Status
Change from base Build 257: -0.2%
Covered Lines: 448
Relevant Lines: 455
💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 261

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 98.462%
Totals Coverage Status
Change from base Build 257: -0.2%
Covered Lines: 448
Relevant Lines: 455
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 261

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 98.462%
Totals Coverage Status
Change from base Build 257: -0.2%
Covered Lines: 448
Relevant Lines: 455
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 261

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 98.462%
Totals Coverage Status
Change from base Build 257: -0.2%
Covered Lines: 448
Relevant Lines: 455
💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 30, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 264

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 98.67%
Totals Coverage Status
Change from base Build 263: -0.4%
Covered Lines: 445
Relevant Lines: 451
💛 - Coveralls

@martin-georgiev martin-georgiev mentioned this pull request Mar 30, 2018
Merged
@martin-georgiev
Copy link
Contributor Author

@Miljar Coverage degradation stated in last report can be probably ignored. It doesn't feel like being relevant in this particular case.

@Miljar Miljar merged commit 45f2570 into PHPExif:master Mar 30, 2018
@martin-georgiev martin-georgiev deleted the php72 branch December 31, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-georgiev @coveralls @Miljar