Skip to content

correctly parse on/off values (w:val="true|false|1|0|on|off") #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2017
Merged

correctly parse on/off values (w:val="true|false|1|0|on|off") #1221

merged 2 commits into from
Dec 18, 2017

Conversation

troosan
Copy link
Contributor

@troosan troosan commented Dec 13, 2017

Description

The value of w:val of type OnOff can be any of http://www.datypic.com/sc/ooxml/t-w_ST_OnOff.html
0, off and false should be treated as false

Fixes #1219

Checklist:

  • I have run phpunit, phpcs, php-cs-fixer, phpmd
  • The new code is covered by unit tests

@troosan troosan merged commit 219f3bc into PHPOffice:develop Dec 18, 2017
@troosan troosan deleted the fix_parsing_of_on-off branch December 18, 2017 07:52
@FBnil
Copy link

FBnil commented Dec 19, 2017

Thanks troosan. It's these little things that make the PHPWord better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect definition of bold text
2 participants
@troosan @FBnil