Allow to set "autoHyphenation" setting #1282
Conversation
|
shouldn't we not also directly implement the following hyphenation options?
|
|
@troosan And maybe: I'll give it a shot. |
|
@troosan Please review :) |
| 'pageBreakBefore' => array(self::READ_TRUE, 'w:pageBreakBefore'), | ||
| 'contextualSpacing' => array(self::READ_TRUE, 'w:contextualSpacing'), | ||
| 'bidi' => array(self::READ_TRUE, 'w:bidi'), | ||
| 'suppressAutoHyphens' => array(self::READ_TRUE, 'w:suppressAutoHyphens'), |
There was a problem hiding this comment.
@troosan Would you mind changing the phpcs align_double_arrow setting? Imho this is a good example what this rule can cause.
There was a problem hiding this comment.
indeed, it's more difficult to view what changed, but it's easier to read the code, no?
There was a problem hiding this comment.
It's not always easier to read the code. Just think of one key with a very long name (doNotUseMarginsForDrawingGridOrigin in document settings, for example). This will cause a lot spaces which makes readability worse because tracking a line with many whitespaces can get exhausting,
But like many other things it's also a matter of personal preference.
to make sure directory is unique [ci skip]
* Improve Title parsing - Title should be able to contain TextRun - Style 'Title' should be treated the same with as Heading - Add tests for Heading/Title reader * update the documentation and the changelog * PHP 7.2 build should not fail anymore * reduce dependencies versions * fix parsing of footnotes and endnotes * add method to remove an element from a section
* Added support for Vertically Raised or Lowered Text (w:position). Note that only docx writing is implemented for now. * Add tests + changelog * add reader + tests + doc
…ub.com/Trainmaster/PHPWord into feature-allow-auto-hyphenation-setting
Description
Added support for automatically hyphenating document contents.
Checklist:
composer run-script check --timeout=0and no errors were reported