New features when creating charts needed for the SurveyGizmo web app #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack charts
Chart colors
Label positions
Merge updates
troosan
previously requested changes
Apr 14, 2018
| $xmlWriter->startElement('c:title'); //start c:title | ||
| $xmlWriter->startElement('c:tx'); //start c:tx | ||
| $xmlWriter->startElement('c:rich'); // start c:rich | ||
| $xmlWriter->writeElementBlock('a:bodyPr'); |
There was a problem hiding this comment.
writeElementBlock expects more attributes, this should be changed to writeElement instead, the same a couple of lines down.
There was a problem hiding this comment.
more generally, check the (very few) warnings in scrutinizer
|
@jaek-s could you please check why when adding a radar graph, the document cannot be opened in word (I have version 2016 for mac) anymore (just run sample_32_chart.php) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello!
I probably should have sent a pull request for my changes much sooner, so I apologize for how massive this pull request has become.
We needed to add some functionality when creating charts with this library in order to fulfill the requirements of our application. We added:
-- stacked bar charts
-- percent stacked bar charts
-- stacked column charts
-- percent stacked column charts
Thanks for looking this over! Let me know if you need any changes.
Fixes # (issue)
Checklist:
composer run-script check --timeout=0and no errors were reported