Skip to content

Drop GitHub pages, switch to coveralls #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 20, 2018
Merged

Drop GitHub pages, switch to coveralls #1360

merged 5 commits into from
May 20, 2018

Conversation

czosel
Copy link
Contributor

@czosel czosel commented Apr 26, 2018 •
edited
Loading

Fixes #1355

@czosel
Copy link
Contributor Author

czosel commented Apr 26, 2018 •
edited
Loading

@troosan I just noticed that you disabled pushing the coverage after builds in the develop branch yesterday. Do you that goes far enough? Is the gh-pages branch still needed?

I just confirmed locally that removing the gh-pages branch (and cleaning up afterwards) reduces the size of .git to 11M.

@czosel
Copy link
Contributor Author

czosel commented Apr 26, 2018

This change would probably also mean moving from scrutinizer to something like coveralls.

@troosan
Copy link
Contributor

troosan commented Apr 29, 2018 •
edited
Loading

indeed, for now I just modified the script not to make it worse on each dev build.
Waiting for @Progi1984's input on this

@czosel
Copy link
Contributor Author

czosel commented May 19, 2018 •
edited
Loading

@troosan Looks like coveralls integration is working! Can you try adding it to the repo?

@czosel czosel changed the title Drop GitHub pages Drop GitHub pages, switch to coveralls May 19, 2018
@czosel czosel mentioned this pull request May 19, 2018
Closed
troosan
troosan reviewed May 20, 2018
View reviewed changes
composer.json Outdated
@@ -61,7 +61,8 @@
"php": "^5.3.3 || ^7.0",
"ext-xml": "*",
"zendframework/zend-escaper": "^2.2",
"phpoffice/common": "^0.2"
"phpoffice/common": "^0.2",
"php-coveralls/php-coveralls": "1.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be in require-dev instead?

@troosan
Copy link
Contributor

troosan commented May 20, 2018

And there is first coveralls report!
@Progi1984 @czosel !

@troosan troosan merged commit cdb3633 into PHPOffice:develop May 20, 2018
@troosan troosan added this to the v0.15.0 milestone May 20, 2018
@czosel czosel deleted the drop-gh-pages branch May 20, 2018 20:20
@czosel
Copy link
Contributor Author

czosel commented May 20, 2018 •
edited
Loading

Thanks for taking over @troosan! The last thing that needs to be done now is to delete the gh-pages branch from the GitHub UI, garbage collection should take care of the rest 👍

Edit: Awesome, looks like it worked 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troosan troosan troosan left review comments

Assignees
No one assigned
Labels
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@czosel @troosan