Skip to content

allows decimal numbers in line-height style #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 14, 2018
Merged

allows decimal numbers in line-height style #1413

merged 15 commits into from
Jul 14, 2018

Conversation

jgpATs2w
Copy link

@jgpATs2w jgpATs2w commented Jun 13, 2018 •
edited by troosan
Loading

Description

Line height with decimals was computed as integer

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

@troosan troosan added this to the v0.15.0 milestone Jul 14, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.839% when pulling 54155bf on jgpATs2w:develop into 9ee99d2 on PHPOffice:develop.

@troosan troosan merged commit 27946ca into PHPOffice:develop Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jgpATs2w @coveralls @troosan