Skip to content

Added PHP 7.3 support for travis #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 16, 2018
Merged

Added PHP 7.3 support for travis #1495

merged 9 commits into from
Nov 16, 2018

Conversation

arzurchris
Copy link
Contributor

No description provided.

@Progi1984 Progi1984 requested a review from troosan October 29, 2018 09:36
@coveralls
Copy link

coveralls commented Oct 29, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 94.838% when pulling 5ca50eb on arzurchris:develop into 1876062 on PHPOffice:develop.

@troosan troosan self-assigned this Nov 16, 2018
troosan
troosan approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@troosan troosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably still a bit premature as some dependencies are not compatible yet, so I allowed myself to modify the travis build to allow that build to fail.

@troosan troosan merged commit ea6edf9 into PHPOffice:develop Nov 16, 2018
troosan pushed a commit to yurii-sio2/PHPWord that referenced this pull request Dec 7, 2018
@arzurchris @troosan
Added PHP 7.3 support for travis (PHPOffice#1495)
dc2f235 
* Added PHP 7.3 support for travis
* mark php 7.3 as failable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troosan troosan troosan approved these changes

Assignees

@troosan troosan

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arzurchris @coveralls @troosan