Skip to content

Conversation

isometriks
Copy link
Contributor

Description

If link target doesn't exist, still add the text anyway.

This has fixed issues for me with broken anchors. If the anchor is broken it just doesn't even create an element in the list and so text is lost. Even if the anchor is broken the content should still be there.

I can write, or attempt to write a unit test for this if this change makes sense.

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

If link target doesn't exist, still add the text anyway.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 94.667% when pulling b1661af on isometriks:patch-1 into 0db21ae on PHPOffice:develop.

@troosan troosan added this to the v0.16.0 milestone Dec 23, 2018
@troosan troosan merged commit e6496bf into PHPOffice:develop Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants