Skip to content

added clone, delete, replace block #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added clone, delete, replace block #165

wants to merge 1 commit into from

Conversation

dv336699
Copy link
Contributor

Because I needed to clone, delete and replace some tables, I added those
functions.

Because I needed to clone, delete and replace some tables, I added those
functions.
@ivanlanin
Copy link
Contributor

Thanks @diego-vieira. Can you please point your pull request to the develop branch? Version 0.8 is stable and we won't make any more changes to it. We're moving to version 0.9 and the repository for that version is the develop branch.

@Progi1984 Progi1984 added this to the 0.9.0 milestone Mar 24, 2014
@Progi1984
Copy link
Member

Thanks @diego-vieira for this PR. Could you add some unit tests, too ?

@ivanlanin ivanlanin mentioned this pull request Mar 24, 2014
@Progi1984 Progi1984 removed this from the 0.9.0 milestone Mar 24, 2014
@dv336699
Copy link
Contributor Author

@ivanlanin oh, didn't know, sorry.
@Progi1984 my bad, will do.

@Progi1984 Progi1984 added this to the 0.9.1 milestone Mar 26, 2014
@ivanlanin
Copy link
Contributor

@diego-vieira I'll help you merge this, but can you please push the docx templates? I can't test the samples without those files. Thanks.

@ivanlanin
Copy link
Contributor

Hi @diego-vieira. Do you still want to merge this pull? Thanks.

@dv336699
Copy link
Contributor Author

dv336699 commented Apr 2, 2014

Hi @ivanlanin sorry for the delay, too much stuff going on.
I'll do as requested.

@ivanlanin
Copy link
Contributor

No problem. Thanks.

@dv336699
Copy link
Contributor Author

dv336699 commented Apr 4, 2014

@ivanlanin really sorry for the delay, I'm going out of the country next week and had lots of stuff to do.
Unfortunately I didn't had time to write the tests (sorry!)

Here is the new PR targeting develop.
#191

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants