Keep image aspect ratio if only 1 dimension styled #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If only one of image width or height is specified, then scale missing dimension to maintain the aspect ratio.
|
Thanks @japonicus. I agree that users would prefer to maintain aspect ratio on most cases. Can you update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only one of image width or height is specified, then scale missing dimension to maintain the aspect ratio.
I suspect that for most use-cases users would prefer to maintain the aspect ratio of images rather than distort them if a width or height style is specified but not both. This small patch sets the missing dimension to maintain the image's aspect ratio.