when adding image to relationship first check that the generated RID is actually unique #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionship id is actually unique
troosan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Occasionally we would have a document fail to add the images and upon further research I discovered the RID generate for the image duplicated an existing RID which caused the images to not appear in the document and some version of Word to complain the document is corrupt. The fix takes the current generation method and checks for if it already exists and simple increments the number until it finds one that doesn't exist.
Fixes # (issue)
potentially 1964 and 1947 and others
Checklist:
composer run-script check --timeout=0and no errors were reported