Skip to content

Add function addcell #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add function addcell #2310

wants to merge 6 commits into from

Conversation

fbclol
Copy link
Contributor

@fbclol fbclol commented Oct 12, 2022 •
edited
Loading

Description

Add function add cell
motivation for use addCell in function addHtml()

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@fbclol fbclol force-pushed the add-function-addCell branch from ebf5e21 to 024fdf9 Compare October 12, 2022 23:18
@fbclol fbclol force-pushed the add-function-addCell branch from 024fdf9 to c995533 Compare October 12, 2022 23:22
@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:07
@fbclol
Copy link
Contributor Author

fbclol commented Dec 21, 2022 •
edited by Progi1984
Loading

Hello,
Can you please check et pull request ? 😄
@Progi1984 ?

Progi1984
Progi1984 reviewed Jan 7, 2023
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbclol Could you add a PHPDoc in the header, please ?

@fbclol
Copy link
Contributor Author

fbclol commented Feb 13, 2023

@fbclol Could you add a PHPDoc in the header, please ?

@Progi1984
what documentation are you talking about?

I think there is nothing to change in the phpdoc of this function

@fbclol fbclol requested a review from Progi1984 May 8, 2023 17:51
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
@coveralls
Copy link

coveralls commented Dec 4, 2024 •
edited
Loading

Coverage Status

coverage: 96.757%. remained the same
when pulling c9289a5 on fbclol:add-function-addCell
into 0ab0b49 on PHPOffice:master.

@fbclol
Copy link
Contributor Author

fbclol commented Dec 4, 2024 •
edited
Loading

I change code in conflicts :)

plz merge @Progi1984

Thx

@Progi1984
Copy link
Member

@fbclol Could you add unit tests ?

@fbclol
Copy link
Contributor Author

fbclol commented Aug 19, 2025

it's OK !

fbclol
fbclol commented Aug 19, 2025
View reviewed changes
Copy link
Contributor Author

@fbclol fbclol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Awaiting requested review from Progi1984

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbclol @coveralls @Progi1984