Ability to apply XSL style sheet to Template #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to apply XSLT to Template
The method name was changed to be more correct.
Signature of the method was changed. Optional parameter should be on the last position.
Correction of the docblock descrition.
Minor changes in exception messages.
Correction of the docblock descrition.
Compatibility with PHP 5.3 was fixed.
FIXED: misprint in test's name.
Final keyword was removed in test class.
Boolean values now meet PHP-FIG.
An attempt to fix tests.
FIXED (again): compatibility with PHP 5.3. FIXED (again): misprint in method name.
FIXED: last negative test.
FIXED: tests (last test was removed, because there is no chance to make it work).
FIXED: indentation.
Notes on error control usage were added.
|
Could you put your pull request on develop branch (#79) ? |
|
All of it? |
|
For your pull request. |
|
Done. #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46