Setting a host/port for Memcached

[Fiorinol]

###Configuration:

PhpFastCache version: 5.0.15
PHP version: 7.0.16
Operating system: Centos 6.8

####Issue description:

I can't figure out how to set a host/port for Memcached using phpFastCache and the example file doesn't state how to do so. I've tried using setDefaultConfig and the second getInstance parameter without success. With just memcached, this is simple enough;

$cache = new memcached();

$cache->addServer("127.0.0.1", 3333);

It works and sets/gets properly.

How do I achieve the same result with phpFastCache? I've tried the following;

$InstanceCache = CacheManager::getInstance("memcached", ['host' => "127.0.0.1",'port' => 3333]);
$key = "product_page";
$CachedString = $InstanceCache->getItem($key);
if (is_null($CachedString->get())) {
//$CachedString = "APC Cache --> Cache Enabled --> Well done !";
// Write products to Cache in 10 minutes with same keyword
$CachedString->set("Memcached Cache --> Cache Enabled --> Well done !")->expiresAfter(120);
$InstanceCache->save($CachedString);
echo "FIRST LOAD // WROTE OBJECT TO CACHE // RELOAD THE PAGE AND SEE // ";
echo $CachedString->get();
} else {
echo "READ FROM CACHE // ";
echo $CachedString->get();
}

But I never to get "Read from cache", indicating that phpFastCache isn't saving properly.

[Geolim4]

Hello,

Try this:

$InstanceCache = CacheManager::getInstance("memcached", ['memcache' =>[ ['host' => "127.0.0.1",'port' => 3333]]]);

The config name is a bit confusing, it may be changing in V6, however in V5 I'll rename "memcache" to "memcached" :)

Cheers,
Georges

[Fiorinol]

I get the same result as before. I never to get "Read from cache" when reloading the page. This is the code currently;

The port number is different because the one I showed in the example was a dummy.

$InstanceCache = CacheManager::getInstance("memcached", ['memcache' =>[ ['host' => "127.0.0.1",'port' => 3452]]]);
$key = "product_page";
$CachedString = $InstanceCache->getItem($key);
if (is_null($CachedString->get())) {
    //$CachedString = "APC Cache --> Cache Enabled --> Well done !";
    // Write products to Cache in 10 minutes with same keyword
    $CachedString->set("Memcached Cache --> Cache Enabled --> Well done !")->expiresAfter(120);
    $InstanceCache->save($CachedString);
    echo "FIRST LOAD // WROTE OBJECT TO CACHE // RELOAD THE PAGE AND SEE // ";
    echo $CachedString->get();
} else {
    echo "READ FROM CACHE // ";
    echo $CachedString->get();
}

And on the centos server, using ps -aux shows that memcached is running on port 3452;

http://i.imgur.com/hMmyd2B.png

The following basic memcached code also functions properly;

$mem = new memcached();

$mem->addServer("127.0.0.1", 3452);

$result = $mem->get("Test");

if ($result) {

echo $result;

} else {

echo "Test key not found, adding key";

$mem->set("Test", "I found a match, memcache is working") or die("Nothing Saved...");

}

I've tried setting memcached to its default port and it works properly;

http://i.imgur.com/lAmyAzx.png

But I don't want to use the default port.

I've noticed as you mentionned in the source that it searches for a "memcache" key in the config array. I've looked at the Memcached driver, and it contains the following function:

protected function driverConnect()
    {
        $servers = (!empty($this->config[ 'memcache' ]) && is_array($this->config[ 'memcache' ]) ? $this->config[ 'memcache' ] : []);
        if (count($servers) < 1) {
            $servers = [
              ['127.0.0.1', 11211],
            ];
        }

        foreach ($servers as $server) {
            try {
                if (!$this->instance->addServer($server[ 0 ], $server[ 1 ])) {
                    $this->fallback = true;
                }
                if(!empty($server[ 'sasl_user' ]) && !empty($server[ 'sasl_password'])){
                    $this->instance->setSaslAuthData($server[ 'sasl_user' ], $server[ 'sasl_password']);
                }
            } catch (\Exception $e) {
                $this->fallback = true;
            }
        }
    }

This line in particular confuses me because it attempts to get key 0 and key 1, which are not assigned in the array, because we set the keys 'host' and 'port';

$this->instance->addServer($server[ 0 ], $server[ 1 ]

Shouldn't this be

$this->instance->addServer($server[ 'host' ], $server[ 'port' ]

This should follow the sasl authentification I think (Which use 'sasl_user' and 'sasl_password'), it makes little sense to use indexed keys for the host/port, but then use associative keys for sasl. Otherwise I'd need to instantiate the CacheManager as follows I suppose;

$InstanceCache = CacheManager::getInstance("memcached", ['memcache' =>[ ["127.0.0.1", 3333]]]);

This really ought to be part of the memcached example or be part of the documentation.

[Geolim4]

I will may review this code partially in V5 and rewrite it completely in V6

[Geolim4]

Let me know if this fix is working (not yet merged).
Thanks :)

[Geolim4]

And because this code needs more logic, here you go..

[Geolim4]

@Fiorinol is it ok for you ?

[Fiorinol]

I've yet to test it, I will do so at the beginning of next week.

[Geolim4]

@Fiorinol Any news about this ? :)

[Geolim4]

@Fiorinol Bump :)

[Geolim4]

I'm considering that issue as resolved, please let me know if it's still not working.

Cheers,
Georges