Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible Error on public function getItemsByTag #771

Closed
GeoSot opened this issue Nov 23, 2020 · 2 comments · Fixed by #772
Closed

Possible Error on public function getItemsByTag #771

GeoSot opened this issue Nov 23, 2020 · 2 comments · Fixed by #772
Assignees
@Geolim4
Labels
0_0 Bug 8.0 :) Closed ^_^ Fixed

Comments

@GeoSot
Copy link
Contributor

GeoSot commented Nov 23, 2020

phpfastcache/lib/Phpfastcache/Core/Pool/TaggableCacheItemPoolTrait.php

Line 168 in 97fa806

if (\array_diff($item->getTags(), $tagName)) {

@github-actions
Copy link

Hello curious contributor !
Since it seems to be your first contribution, make sure that you've been:

  • Reading and searching out our WIKI
  • Reading and agreed with our Code Of Conduct
  • Reading and understood our Coding Guideline
  • Reading our README
    If everything looks unclear to you, tell us what 😄
    The Phpfastcache Team

@GeoSot GeoSot closed this as completed Nov 23, 2020
@Geolim4
Copy link
Member

Geolim4 commented Nov 23, 2020

Fixed in #772 :)

@Geolim4 Geolim4 self-assigned this Nov 23, 2020
@Geolim4 Geolim4 linked a pull request Nov 23, 2020 that will close this issue
DeleteItemsByTags was ignoring strategy #772
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geolim4 Geolim4

Labels
0_0 Bug 8.0 :) Closed ^_^ Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DeleteItemsByTags was ignoring strategy
2 participants
@Geolim4 @GeoSot