Skip to content

Fixed TypeError in lib/Phpfastcache/Drivers/Cookie/Driver.php #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Fixed TypeError in lib/Phpfastcache/Drivers/Cookie/Driver.php #716

merged 1 commit into from
Dec 17, 2019

Conversation

motikan2010
Copy link
Contributor

Proposed changes

docs/examples/cookie.php in PHP 7.1.25. An error has occurred the following.

Fatal error: Uncaught TypeError: setcookie() expects parameter 2 to be string, integer given in /Users/admin/PhpstormProjects/SampleProject/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Cookie/Driver.php on line 52

TypeError: setcookie() expects parameter 2 to be string, integer given in /Users/admin/PhpstormProjects/SampleProject/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Cookie/Driver.php on line 52

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Geolim4
Copy link
Member

Geolim4 commented Dec 17, 2019

Thanks for the fix !

@Geolim4 Geolim4 merged commit cb0819a into PHPSocialNetwork:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants