-
-
Notifications
You must be signed in to change notification settings - Fork 452
chore: support psr/cache:2 compatibility layer #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @bshaffer, I already tried to support both version but its not working neither, I think that there is one more blocking dependency:
|
@Geolim4 thank you for your comment, but that does not have anything to do with this PR, but rather with the |
Yes and no, this PR will still be blocked until the |
@Geolim4 no it won't be. This library does not rely on |
The library will rely on Like I'm actually doing for every other backend (Mongodb, Couchbase, Couchdb, etc). However, the tests on the CI will install the full deps suggestion list to test EVERY supported backend (See Travis.yml). So actually I'm blocked by
|
Thanks for the PR @bshaffer I have to also update the .lock in another commit but its fine. |
Proposed changes
Adds support the
psr/cache:2
compatibility layer. This will allow projects which are still onpsr/cache:1
to be installed alongside this library on PHP 8.Any library which supports
psr/cache:1
can supportpsr/cache:2
, and any library that can supportpsr/cache:3
can also supportpsr/cache:2
, without breaking anyone or making any changes. This allows everyone to coexist until they can add support forpsr/cache:3
See googleapis/google-auth-library-php#363 for an example of the issue which takes place now, and why we cannot easily fix it.
Types of changes
What types of changes does your code introduce to Phpfastcache?
Put an
x
in the boxes that applyAgreement
I have read the CONTRIBUTING and CODING GUIDELINE docs