This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Add simple CI #16
Merged
Add simple CI #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Nov 16, 2020
keradus
reviewed
Nov 16, 2020
| @@ -14,7 +14,7 @@ | |||
| "phpunit/phpunit": "^4.8.36 || ^5.7.27 || ^6.5.14 || ^7.5.20 || ^8.0 || ^9.0" | |||
| }, | |||
| "require-dev": { | |||
| "friendsofphp/php-cs-fixer": "^2.16" | |||
| "friendsofphp/php-cs-fixer": "^2" | |||
There was a problem hiding this comment.
Because of this: https://github.com/sanmai/polyfill/runs/1406796543?check_suite_focus=true
It's easier than to follow a full dev-tools/.phar approach, right at the moment.
There was a problem hiding this comment.
issue is that if you run php-cs-fixer 2.0 it may apply some other CodeStyle and expect them to be applied, while we are following ruleset of 2.16.
There was a problem hiding this comment.
True, but we ain't going to run php-cs-fixer on PHP 5.6, are we?
There's a dedicated CS workflow, that uses PHP 7.4 to verify the work.
sanmai
commented
Nov 17, 2020
sanmai
commented
Nov 17, 2020
sanmai
commented
Nov 17, 2020
keradus
approved these changes
Nov 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://github.com/sanmai/polyfill/actions/runs/366177606