Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable undelegation on hardware wallets #292

Merged
merged 8 commits into from
Jan 31, 2024

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Jan 30, 2024

Abstract

Ledgers should be able to undelegate. This enables users to follow this guide
https://forum.pivx.org/threads/how-to-setup-cold-staking-with-ledger-hardware-wallet.650/.

(Disclaimer: I haven't tested this, as I don't have my ledger with me)

Testing

  • Send a p2cs tx to a ledger address (This can be done with MPW by toggling advanced mode)
  • Check that you can spend the tx on ledger

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 0f8a54b
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/65ba4074d5e3b000084b019f
😎 Deploy Preview https://deploy-preview-292--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Duddino Duddino self-assigned this Jan 30, 2024
@Duddino Duddino added the Bug This is either a bugfix (PR) or a bug (issue). label Jan 30, 2024
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 0f8a54b
Final commit fixed the issue of unstaking from a Ledger HW

Copy link
Member Author

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l3chu tested this as well, and worked for him without issue.

@Duddino Duddino merged commit 3243079 into PIVX-Labs:master Jan 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants