Update txid in fromHex #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
panleone
reviewed
Mar 6, 2024
scripts/transaction.js
Outdated
| @@ -94,6 +94,7 @@ export class Transaction { | |||
| shieldSpend = [], | |||
| shieldOutput = [], | |||
| bindingSig = '', | |||
| txid, | |||
There was a problem hiding this comment.
unused parameter in the constructor
scripts/transaction.js
Outdated
| @@ -105,11 +106,14 @@ export class Transaction { | |||
| this.shieldOutput = shieldOutput; | |||
| this.bindingSig = bindingSig; | |||
| this.valueBalance = valueBalance; | |||
| this.#txid = txid; | |||
JSKitty
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
tACK da03c23
I've been comparing with multiple tests against master and getting consistent improvements, my wallet is far smaller than yours so the magnitude is much less (about a 10% speed increase) but definitely noticeable in the performance captures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
MPW was spending a lot of time serializing the transaction when calculating the txid.
To prevent this, we can calculate the txid during the serialization, when we have the hex.
This is the benchmark before the PR, on a very big testnet wallet:
This is after:
Testing
Test that the general functionality works