Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphaned transaction time mismatch #510

Closed
DSofter opened this issue Jan 24, 2018 · 8 comments · Fixed by #939
Closed

Orphaned transaction time mismatch #510

DSofter opened this issue Jan 24, 2018 · 8 comments · Fixed by #939
Assignees
@Warrows
Labels
Bug GUI

Comments

@DSofter
Copy link

DSofter commented Jan 24, 2018

This issue tracker is only for technical issues related to PIVX Core.
General PIVX questions and/or support requests and are best directed to the PIVX Discord.

Describe the issue

Hello PIVX devs! I'm seeing transaction time mismatch on my desktop wallet.

On the transaction list, the tx happened at 1/19/2018 23:30, as shown in the below screenshot:
image

However in the blockchain explorer, the tx happened at 1/20/2018 18:15
image

I don't know if it might be the cause, but I'm only noticing such behavior on orphaned transactions. The transaction I posted above is an orphaned transaction.
image

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. I resynced my wallet and the issue is still there.

Expected behavior

The time of the transaction should match between the transaction list and the block explorer.

Actual behavior

The time of the transaction didn't match between the transaction list and the block explorer.

Screenshots.

Posted above.

What version of PIVX Core are you using?

3.0.6
@Warrows
Copy link

Warrows commented Jan 24, 2018 •
edited
Loading

Thanks for reporting.
It's actually a duplicate of #204 which was automatically closed when #498 was merged because I suggested it might fix it. Not absolutely sure it's the case though.
Did you try starting your wallet with arg -zapwallettxes ?

@DSofter
Copy link
Author

DSofter commented Jan 24, 2018

Lemme try that! Thanks for the quick response! @Warrows

@DSofter
Copy link
Author

DSofter commented Jan 24, 2018

@Warrows Actually, although #498 was merged, do I still need to wait for the new release, or download and compile the latest code before trying -zapwallettxes?

@Warrows
Copy link

Warrows commented Jan 24, 2018

@DSofter as a first step you can go ahead and zap with your current wallet. If it doesn't work I would be very interested in you trying to zap with binaries compiled from master.

@DSofter
Copy link
Author

DSofter commented Jan 25, 2018

@Warrows may i also ask what the zapwallettxes command does?

@Warrows
Copy link

Warrows commented Jan 25, 2018 •
edited
Loading

It's going to remove all TX from memory and rescan the blockchain to add them all back. It can be a long process if you have a lot of transactions.
Of course I advise you to backup wallet.dat before any of these operations as a simple safety measure.

@Mrs-X Mrs-X closed this as completed Mar 31, 2018
@Warrows
Copy link

Warrows commented May 21, 2018

Looks like it's not really fixed after all. A user reported it again a few days ago.
capture

@Warrows Warrows reopened this May 21, 2018
@Warrows Warrows added the Bug label Jun 1, 2018
@Warrows Warrows mentioned this issue Jun 8, 2018
Closed
@Warrows Warrows self-assigned this Jun 8, 2018
@mhannigan
Copy link

This happens quite reliably for me and has for many versions back.

A sent transaction will be put into the wallet at a previous orphan until (I believe) each orphan has a corresponding send transaction.

@Fuzzbawls Fuzzbawls added the GUI label Oct 13, 2018
@Warrows Warrows mentioned this issue Dec 25, 2018
Closed
Warrows added a commit to Warrows/PIVX that referenced this issue Jul 2, 2019
@Warrows
[Wallet] Remove (explicitely) unused tx comparator
1f224d3 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project#510
So this change fixes PIVX-Project#510.
@Warrows Warrows mentioned this issue Jul 2, 2019
Merged
Warrows added a commit to Warrows/PIVX that referenced this issue Jul 11, 2019
@Warrows
[Wallet] Remove (explicitely) unused tx comparator
3da857b 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project#510
So this change fixes PIVX-Project#510.
Fuzzbawls added a commit that referenced this issue Jul 28, 2019
@Fuzzbawls
Merge #939: [Wallet] Remove (explicitely) unused tx comparator
37ad934 
3da857b [Wallet] Remove (explicitely) unused tx comparator (warrows)

Pull request description:

  '==' and '!=' operators in CMutableTransaction are never used explicitly.
  Them being used implicitly is probably what causes #510. There is no good reason to keep them and BTC removed them here: bitcoin#13443
  Should fix #510

ACKs for top commit:
  Fuzzbawls:
    ACK 3da857b

Tree-SHA512: f5874d794b0a43b1290c977b10d16b1a8078b09862886f34bcdcc65e5a1ef2b9eb1c3e43dfe4711861609cf5a6c92d35180e37a95f5d5afcbac16854d5189dee
random-zebra pushed a commit to random-zebra/PIVX that referenced this issue Aug 2, 2019
@Warrows @random-zebra
[Wallet] Remove (explicitely) unused tx comparator
1f05e1e 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project#510
So this change fixes PIVX-Project#510.
cpass78 pushed a commit to Block-Logic-Technology-Group/bltg that referenced this issue Aug 17, 2019
@Warrows
[Wallet] Remove (explicitely) unused tx comparator
70fed38 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.

(cherry picked from commit 3da857b52879c186295057a5f91ec731cd65e3de)
FornaxA pushed a commit to FornaxA/ion that referenced this issue Aug 24, 2019
@Warrows @FornaxA
Remove (explicitely) unused tx comparator
0817089 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
FornaxA pushed a commit to FornaxA/ion that referenced this issue Aug 24, 2019
@Warrows @FornaxA
Remove (explicitely) unused tx comparator
346b311 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
FornaxA pushed a commit to FornaxA/ion that referenced this issue Aug 25, 2019
@Warrows @FornaxA
Remove (explicitely) unused tx comparator
b5ebcd1 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
FornaxA pushed a commit to FornaxA/ion that referenced this issue Aug 26, 2019
@Warrows @FornaxA
Remove (explicitely) unused tx comparator
055b4d8 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
ioncoincore pushed a commit to ioncoincore/ion-v4 that referenced this issue Aug 26, 2019
@FornaxA @ioncoincore
Upstream upgrades: maintainence, bug fixes
0383fda 
Overview of adapted commits: https://github.com/FornaxA/ion/commits/0672b609a3bb0ec801eb2f4fc79033b64406ab7b

PR includes adapted versions of these original commits:

From cd9a6edfea46572aa16ae841b82976dd320dcaa3 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 11 Jul 2019 01:59:47 -0700
Subject: [PATCH] [Scripts] Sync github-merge.py with upstream

Pulls in further updates to the script from upstream since #921 was
merged.

From 3da857b52879c186295057a5f91ec731cd65e3de Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 2 Jul 2019 14:56:27 +0200
Subject: [PATCH] [Wallet] Remove (explicitely) unused tx comparator

    We remove the '==' and '!=' operators from CMutableTransaction.
    These comparators are never explicitely used in our code.
    As it turns out, it was used implicitely and created this situation:
    PIVX-Project/PIVX#510
    So this change fixes #510.

From 604d365c5ee12c2273789fd3afa2f496e8550eb1 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sat, 13 Jul 2019 12:23:43 +0200
Subject: [PATCH] [Refactor] Remove all "using namespace" statements

    This goes towards following more closely the coding guidelines.

From ef41333993fc7f9a8b1a845766b68f15576bd4c2 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sat, 13 Jul 2019 12:45:19 +0200
Subject: [PATCH] [Refactor] Replace tabs with spaces

From 42fe4040acff08450168416ccf35413abdc1747a Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 3 Jul 2019 22:45:35 -0700
Subject: [PATCH] [Refactor] Move ThreadStakeMinter out of net.cpp

    This moves the implementation function and thread creation to a more
    appropriate file (`miner.cpp`).

From ae0b1b5 Mon Sep 17 00:00:00 2001
From: FornaxA <fornaxa@servitising.org>
Date: Sat, 24 Aug 2019 10:45:04 +0200
Subject: [PATCH] Re-add removed functionality from test_runner.py

From 20aab1152afa3a0ef71ffeb05d4dd4eb171ba116 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Jul 2019 13:45:09 +0200
Subject: [PATCH] [Tests] Do not fail when warnings are written to stderr

    print stderr with the test result instead

From c9a2cc35d201421b3de20a539f1598372a36efae Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 13 Jul 2019 18:41:03 -0400
Subject: [PATCH] Trivial: typo fixes

From 639b43dee61c5d918bc5538eb563de376d51ee78 Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 20 Jul 2019 19:45:06 -0400
Subject: [PATCH] [Trivial] Spelling - Wither -> Whether

From 139d333dd9c294e13115bfd8e1b1a8d7ad1e9d2e Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sun, 14 Jul 2019 20:26:13 -0400
Subject: [PATCH] Minting: Prevent potential negative out values

From 12c44cafdeb49ec0b5fbe5815cb4fa431bc2a934 Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 1 Aug 2019 09:15:40 -0300
Subject: [PATCH] [Wallet][xION] zc public spend parse crash in wallet startup
 fixed.

From 983d97a86c6450c85a0411eed5b533e3109c1aea Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 13 Jul 2019 17:39:58 -0400
Subject: [PATCH] [Refactor] Combine parameter checking of budget commands

From 421956f80325331bd145c83e4e182687dfe13c00 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 2 Aug 2019 05:18:20 +0200
Subject: [PATCH] [Tests] Add Spork functional test and update RegTest spork
 key

From db702dcc200f9c70562039d422de2ec36c3248f9 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 2 Aug 2019 12:17:54 +0200
Subject: [PATCH] [Tests] Enable Spork messages on RegTest net

From f7ac53b2d5de29951240718680443b62acfa6db2 Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 27 Jul 2019 13:36:55 -0400
Subject: [PATCH] [RPC] Correct issues with budget commands

From 72611349f10c94de54162ab1a226a81dd9af35fd Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Thu, 1 Aug 2019 21:52:28 -0400
Subject: [PATCH] [Review] Convert runtime_error to JSONRPCError

From 2eacdb7f46673de758dd273a53effe25cfd73a1f Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 6 Aug 2019 21:03:58 +0200
Subject: [PATCH] [Refactor] Fix stake age checks for regtest

    - fix age check in CheckProofOfStake
    - move nStakeMinAge to chain params
    - fix error logs in kernel.cpp

From b7a9a9cdb20cdee869906fb24e2bc984e8a93802 Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sun, 21 Jul 2019 16:00:25 -0400
Subject: [PATCH] [Staking] Modify miner and staking thread for efficency
Kokary pushed a commit to Kokary/wagerr that referenced this issue Sep 20, 2019
@Warrows @Kokary
Remove (explicitely) unused tx comparator
da15775 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
Kokary pushed a commit to Kokary/wagerr that referenced this issue Sep 20, 2019
@Warrows @Kokary
Remove (explicitely) unused tx comparator
73df595 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
Kokary pushed a commit to Kokary/wagerr that referenced this issue Sep 20, 2019
@Warrows @Kokary
Remove (explicitely) unused tx comparator
172d7d2 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
Kokary pushed a commit to Kokary/wagerr that referenced this issue Sep 25, 2019
@Warrows @Kokary
Remove (explicitely) unused tx comparator
5107b5b 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
Kokary pushed a commit to Kokary/wagerr that referenced this issue Sep 25, 2019
@Warrows @Kokary
Remove (explicitely) unused tx comparator
8595c39 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
Kokary pushed a commit to Kokary/wagerr that referenced this issue Nov 1, 2019
@Warrows @Kokary
Remove (explicitely) unused tx comparator
ab2bf5c 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
Kokary added a commit to wagerr/wagerr that referenced this issue Nov 1, 2019
@Kokary
Upstream updates, including new stake modifier (#175)
e67b066 
* Do all block index writes in a batch

Backport from bitcoin bitcoin/bitcoin#5367

* Add blockhash + datadir to information tab

* Fix permissions

* show the progress of functional test

example (added the progress index `n/m`)
```
1/107 - wallet_hd.py passed, Duration: 27 s
.........................................................................................
2/107 - mining_getblocktemplate_longpoll.py passed, Duration: 72 s
..................................................................
3/107 - feature_maxuploadtarget.py passed, Duration: 78 s
```

- clear dots line
```
$ test/functional/test_runner.py -t can_trash
Temporary test directory at can_trash/test_runner_₿_🏃_20181018_220600
1/105 - wallet_hd.py passed, Duration: 21 s
2/105 - mining_getblocktemplate_longpoll.py passed, Duration: 71 s
3/105 - feature_maxuploadtarget.py passed, Duration: 68 s
..................
```

- don't print the `dot` progressive if `--quiet`

- done_str
- nothing commit to check again travis tests

* tests: Print dots by default

* tests: Print remaining jobs in test_runner.py

This helps finding out which tests fail to finish.

* travis: Fix caching issues

* Log more info

* Use references instead of copies in for loops

turning on `-Wrange-loop-analysis` shows a number of compiler warnings
with c++11 for loops creating copies when references would suffice.

This cleans up those warnings.

* travis: Use absolute paths for cache dirs

* Remove (explicitely) unused tx comparator

We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.

* Give more time to tests

Travis was regularly failing because the full test suite with coverage
takestoo much time.
Bitcoin has some optimisations in there which allows them to give less
time to the test part of the process. We don't so until we do, we have
to reserve more time. We will probably have to restart manually more
travis jobs but that's the only way to have them run to the end.

* Sync github-merge.py with upstream

Pulls in further updates to the script from upstream since #921 was
merged.

* Move ThreadStakeMinter out of net.cpp

This moves the implementation function and thread creation to a more
appropriate file (`miner.cpp`).

* Remove all "using namespace" statements

This goes towards following more closely the coding guidelines.

* Replace tabs with spaces

* Add info about '--with-unsupported-ssl'

Compilation with openssl version more recent than 1.0.1 is not advised but still possible. We need t let self compilers know about that.

* Trivial: typo fixes

* Spelling - Wither -> Whether

* Do not fail when warnings are written to stderr

print stderr with the test result instead

* zc public spend parse crash in wallet startup fixed.

* Combine parameter checking of budget commands

* Correct issues with budget commands

* Convert runtime_error to JSONRPCError

* Add Spork functional test and update RegTest spork key

Signed off by: FornaxA

* Enable Spork messages on RegTest net

* Remove GetCoinAge

This function is never used, and never will be; Nuke it from orbit.

* require valid URL scheme on budget commands

* Modify miner and staking thread for efficency

* Remove Bitcoin Core 0.8 block hardlinking

* Don't create new keys when generating PoS blocks

key creation for coinbase output is a waste for PoS blocks and can be removed

* Upstream upgrades: stake modifier V2

Overview of original commits: https://github.com/PIVX-Project/PIVX/pull/983/commits

PR includes adapted versions of these original commits:

commit bf1651452cef40f72f6edc4a71515c15a24c6264
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 25 23:59:37 2019 +0200

    [Consensus] New modifier enforcement height changed for mainnet

commit 6b6ef3232ded7280479103fe861585e56c1500d4
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Sun Aug 25 14:36:57 2019 -0700

    Don't load old stake modifier from disk after changeover height

commit d085ed0a749c058565da9634f7e2b137c9d331b4
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 25 16:44:35 2019 +0200

    [Consensus] Fix old block version check (including v.6)

commit b1416f51e23d137ab24cfb816fec61db4da49b46
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 25 12:15:05 2019 +0200

    [Tests] fix blocks/maturity fakestake_accepted

commit c212587680a739dc33309dfe7a90e0cc0fd0329d
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 25 12:14:26 2019 +0200

    [PoS] fix regtest nBlockStakeModifierlV2 and cbase maturity

commit dddca50c3d0483bec1028d9a649e317a3c802305
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Fri Aug 23 21:04:25 2019 -0700

    Use better JSON key names in block coinstake output

    Also add help description for new keys

commit 28351113255136779a76f2af72d08ca781f774c2
Author: Fuzzbawls <fuzzbawls@gmail.com>
Date:   Fri Aug 23 20:03:45 2019 -0700

    Don't shadow global fDebug

    conditional log output in kernel.cpp functions can use the global fDebug variable instead of their own.

commit 85fa96eadd69fe8913b8028cb63b1d327df0a004
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Fri Aug 23 23:14:05 2019 -0300

    [Consensus] New modifier enforcement height set.

commit a74f6cf848cdd024e3513669e75b0d7e76492ec3
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Sat Aug 17 14:50:28 2019 -0300

    [GUI] sendCoinsdialog, removing zero tx fee checkbox and label.

commit 6a33fffd0fbd74f673afe9673a77d1d0875f4118
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed Aug 14 15:01:11 2019 -0300

    [Mempool] // As zero fee transactions are not going to be accepted in the near future (4.0) and the code will be fully refactored soon.
              // This is just a quick inline towards that goal, the mempool by default will not accept them. Blocking
              // any subsequent network relay.

    [SQUASH] Permitting free txes only in regtest.

commit 6c69cfef4da94b83eb7aecf383f0d5e837da538d
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 22 17:13:14 2019 -0300

    [PoS] * GetKernelStakeModifier, look for the next block in the mapBlockIndex and not in the chainActive and look for it based on the next block hash and not based on height.
        * Contextual zPIV stake, invalid height contextual check, using tip instead of prev height + 1.

commit d3db3e621ca65fa6f0b1916611cbc83388c146a0
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed Aug 21 04:25:25 2019 +0200

    [PoS] Stake(): Add check for staked blocks in the future

commit f8777c649dec25a7d59119e16e331059d0e8483d
Author: random-zebra <random.zebra@protonmail.com>
Date:   Wed Aug 21 00:22:55 2019 +0200

    [Refactor] Add future block time drift to chainparams

commit 8c7522bb88042098dc531835add65a7394be7751
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 22 12:37:48 2019 -0300

    [PoS] Compute old modifier, invalid integer division removal plus extra logging for the stake modifier height added.

commit beaba470d90875c857736084e7f85cccae9b91d9
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed Aug 21 16:55:37 2019 -0300

    [RPC] getblock, validate that PoS blocks to return the coin stake data.

commit 81446bba545ec46c58bfc5316ef32e46298af6d0
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed Aug 21 14:23:49 2019 -0300

    [PoS][RPC] getblock command, adding more information about the coin stake tx.

commit 820e08c1645031a06065ea369c8673d5f9559a07
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Wed Aug 21 12:01:45 2019 -0300

    [PoS][RPC][Refactor] GetHashProofOfStake and initStakeInput methods created, better method responsibility division from the CheckStakeKernelHash to be able to get the information for the getblock rpc command and possible future tests.

commit 4d5cc97e76a30b669f9574a2fc080cdff83b588d
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon Aug 19 15:38:04 2019 -0300

    [Wallet] Staking, unreacheable code removed..

commit 41ccf6b86b48949fc18dae6728359f87073770b1
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon Aug 19 15:28:21 2019 -0300

    [PoS][Wallet] CreateCoinStake, if the block is from the future then start on a future time.

commit ffb0dd558d8cba9d06ed3dd68eaa371f245780d0
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon Aug 19 12:16:14 2019 -0300

    [Trivial] logging, removing none required jump lines.

    [Trivial] Cleaning jump lines in not needed logging.

commit 843dc56cd6a119861cff8eb21ee9a969a08480bd
Author: random-zebra <random.zebra@protonmail.com>
Date:   Mon Aug 19 16:18:07 2019 +0200

    [PoS] Allign ComputeStakeModifier (v2) to nHeight logic

    [PoS] cleaning not used stakeTargetHit method + fixing bad nHeight in
    the new compute modifier method.

commit 4c2493470ff4afcfba5b49cf53b2a73a28a0c0a2
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Mon Aug 19 11:13:34 2019 -0300

    [PoS] read/write block index modifier based on height and not block version.

commit 6297e7745ac3b714e67adaeefd67c635d4675294
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sun Aug 18 15:22:01 2019 +0200

    [Core] Introduce Blocks version 6

    [SQUASH] Cleanup proof-of-stake debug log

commit b8c59aed098bb89a7debbd05ab54198879a443ca
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Sat Aug 17 00:16:35 2019 -0300

    [PoS] CheckStakeKernelHash, was checking the previous block instead of
    the block under review.

    [PoS] CheckProofOfStake, stop searching a block on disk when it's
    absolutely not needed.
     * Not used variable nTargetTimespan in chainParams removed.

commit 0d31ac2e9bc659181ecd4ac2bb904ff7db984318
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Fri Aug 16 23:42:04 2019 -0300

    [Wallet] HasMintableCoins, don't call GetAdjustedTime on every cycle of the loop.

commit d94931f9a30bc6406ba588417663fcb280a565ff
Author: random-zebra <random.zebra@protonmail.com>
Date:   Sat Aug 17 03:26:09 2019 +0200

    [Trivial] Add logs to CheckKernelHash

    [SQUASH] Fix nTimeTx bug in Stake()

commit eab9944d064b647a1485dd9a00713696c82023da
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Fri Aug 16 19:56:25 2019 -0300

    version bumped

commit 117f815458a828d1e8e7c564c2e5a79a5387d0fa
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri Aug 16 22:25:19 2019 +0200

    [PoS] New logic for stake input maturity

    require it to be nStakeMinDepth deep instead of nStkaMinAge old.

commit d805952ea52b5ebb977b654c6ca108df3fd9e934
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri Aug 16 02:13:41 2019 +0200

    [Wallet] SelectStakeCoins using block time and fix GetBlocksToMaturity

commit 01ed69a471c6fa19761103a1f1917d1930e83526
Author: random-zebra <random.zebra@protonmail.com>
Date:   Fri Aug 16 02:03:53 2019 +0200

    [PoS] Remove extra nTime check in Stake()

commit 74d85c2a42f864f734adb2a994c1ab9c2a792a45
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 15 17:02:33 2019 -0300

    [Refactor][PoS] Do not calculate the prevBlock medianTimePast on every cycle of the CreateCoinStake loop.

commit a48a7a503afb5210483f7d1b238ea07a1883dfd0
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 15 17:00:45 2019 -0300

    [Trivial] Compiler warning, uint_32 compared against int.

commit e9c07d0749d3b99374af956eeae87962ddbdb9e6
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Thu Aug 15 12:25:16 2019 -0300

    [Consensus] V2 modifier protocol change, two new fields in chainparams nStakeMinAgeV2Modifier and nMaturityV2Modifier.

commit 3b97fc0cac807cb4e311780daa16da752c440020
Author: furszy <matiasfurszyfer@protonmail.com>
Date:   Tue Aug 13 20:12:31 2019 -0300

    [PoS] Cleaning GetStakeModifierSelectionInterval() constant method +
    other redundancies.

    [PoS][Refactor] CPivStake, caching data + removing redundant method
    calls.

    [PoS] Fix error in nSelectionIntervalStart integer division

commit 3c1fd7a838c5ed8e271bb2f83eb9e7f19ddf10be
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Aug 13 23:34:25 2019 +0200

    [PoS] Stake Modifier V2

commit f73a27f0b7ac392718efc83de1741830566ff68d
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Aug 13 22:04:15 2019 +0200

    [Core] Do not check block if it's not the one needed

    also there's no need to count mints and spends here

commit 1e4c86421d1b0410a7edee284cdb33df672eaea8
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Aug 13 22:01:21 2019 +0200

    [Cleanup] Clean error messages in CheckBlock

    [Cleanup] Remove unused 'GetWeight()' function

    [Cleanup] Remove unneeded variables

commit 401a986e9f79a869edff74faaea452bded32cf5b
Author: random-zebra <random.zebra@protonmail.com>
Date:   Tue Aug 13 21:49:43 2019 +0200

    [Consensus] Placeholder block height for modifier V2 enforcement
Stamek pushed a commit to Stamek/squorum that referenced this issue Mar 15, 2020
@Warrows @Stamek
[Wallet] Remove (explicitely) unused tx comparator
19e3c73 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project/PIVX#510
So this change fixes #510.
KolbyML pushed a commit to KolbyML/bitcoin that referenced this issue Nov 21, 2020
@Warrows @KolbyML
[Wallet] Remove (explicitely) unused tx comparator
9392f0a 
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
PIVX-Project#510
So this change fixes bitcoin#510.
cryptolinux pushed a commit to cryptolinux/ion that referenced this issue Feb 6, 2021
@FornaxA
Upstream upgrades: maintainence, bug fixes
36eed28 
Overview of adapted commits: https://github.com/FornaxA/ion/commits/0672b609a3bb0ec801eb2f4fc79033b64406ab7b

PR includes adapted versions of these original commits:

From cd9a6ed Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 11 Jul 2019 01:59:47 -0700
Subject: [PATCH] [Scripts] Sync github-merge.py with upstream

Pulls in further updates to the script from upstream since dashpay#921 was
merged.

From 3da857b Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 2 Jul 2019 14:56:27 +0200
Subject: [PATCH] [Wallet] Remove (explicitely) unused tx comparator

    We remove the '==' and '!=' operators from CMutableTransaction.
    These comparators are never explicitely used in our code.
    As it turns out, it was used implicitely and created this situation:
    PIVX-Project#510
    So this change fixes dashpay#510.

From 604d365 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sat, 13 Jul 2019 12:23:43 +0200
Subject: [PATCH] [Refactor] Remove all "using namespace" statements

    This goes towards following more closely the coding guidelines.

From ef41333 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sat, 13 Jul 2019 12:45:19 +0200
Subject: [PATCH] [Refactor] Replace tabs with spaces

From 42fe404 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 3 Jul 2019 22:45:35 -0700
Subject: [PATCH] [Refactor] Move ThreadStakeMinter out of net.cpp

    This moves the implementation function and thread creation to a more
    appropriate file (`miner.cpp`).

From ae0b1b55f0ce202373cdd3e3133f48438bbbc98b Mon Sep 17 00:00:00 2001
From: FornaxA <fornaxa@servitising.org>
Date: Sat, 24 Aug 2019 10:45:04 +0200
Subject: [PATCH] Re-add removed functionality from test_runner.py

From 20aab11 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Jul 2019 13:45:09 +0200
Subject: [PATCH] [Tests] Do not fail when warnings are written to stderr

    print stderr with the test result instead

From c9a2cc3 Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 13 Jul 2019 18:41:03 -0400
Subject: [PATCH] Trivial: typo fixes

From 639b43d Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 20 Jul 2019 19:45:06 -0400
Subject: [PATCH] [Trivial] Spelling - Wither -> Whether

From 139d333 Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sun, 14 Jul 2019 20:26:13 -0400
Subject: [PATCH] Minting: Prevent potential negative out values

From 12c44ca Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 1 Aug 2019 09:15:40 -0300
Subject: [PATCH] [Wallet][xION] zc public spend parse crash in wallet startup
 fixed.

From 983d97a Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 13 Jul 2019 17:39:58 -0400
Subject: [PATCH] [Refactor] Combine parameter checking of budget commands

From 421956f Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 2 Aug 2019 05:18:20 +0200
Subject: [PATCH] [Tests] Add Spork functional test and update RegTest spork
 key

From db702dc Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 2 Aug 2019 12:17:54 +0200
Subject: [PATCH] [Tests] Enable Spork messages on RegTest net

From f7ac53b Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 27 Jul 2019 13:36:55 -0400
Subject: [PATCH] [RPC] Correct issues with budget commands

From 7261134 Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Thu, 1 Aug 2019 21:52:28 -0400
Subject: [PATCH] [Review] Convert runtime_error to JSONRPCError

From 2eacdb7 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 6 Aug 2019 21:03:58 +0200
Subject: [PATCH] [Refactor] Fix stake age checks for regtest

    - fix age check in CheckProofOfStake
    - move nStakeMinAge to chain params
    - fix error logs in kernel.cpp

From b7a9a9c Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sun, 21 Jul 2019 16:00:25 -0400
Subject: [PATCH] [Staking] Modify miner and staking thread for efficency
ckti pushed a commit to ckti-gitian-ion/ion that referenced this issue Mar 29, 2021
@FornaxA @ckti
Upstream upgrades: maintainence, bug fixes
7d987cc 
Overview of adapted commits: https://github.com/FornaxA/ion/commits/0672b609a3bb0ec801eb2f4fc79033b64406ab7b

PR includes adapted versions of these original commits:

From cd9a6ed Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Thu, 11 Jul 2019 01:59:47 -0700
Subject: [PATCH] [Scripts] Sync github-merge.py with upstream

Pulls in further updates to the script from upstream since dashpay#921 was
merged.

From 3da857b Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Tue, 2 Jul 2019 14:56:27 +0200
Subject: [PATCH] [Wallet] Remove (explicitely) unused tx comparator

    We remove the '==' and '!=' operators from CMutableTransaction.
    These comparators are never explicitely used in our code.
    As it turns out, it was used implicitely and created this situation:
    PIVX-Project#510
    So this change fixes dashpay#510.

From 604d365 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sat, 13 Jul 2019 12:23:43 +0200
Subject: [PATCH] [Refactor] Remove all "using namespace" statements

    This goes towards following more closely the coding guidelines.

From ef41333 Mon Sep 17 00:00:00 2001
From: warrows <warrows@gamer666.fr>
Date: Sat, 13 Jul 2019 12:45:19 +0200
Subject: [PATCH] [Refactor] Replace tabs with spaces

From 42fe404 Mon Sep 17 00:00:00 2001
From: Fuzzbawls <fuzzbawls@gmail.com>
Date: Wed, 3 Jul 2019 22:45:35 -0700
Subject: [PATCH] [Refactor] Move ThreadStakeMinter out of net.cpp

    This moves the implementation function and thread creation to a more
    appropriate file (`miner.cpp`).

From ae0b1b55f0ce202373cdd3e3133f48438bbbc98b Mon Sep 17 00:00:00 2001
From: FornaxA <fornaxa@servitising.org>
Date: Sat, 24 Aug 2019 10:45:04 +0200
Subject: [PATCH] Re-add removed functionality from test_runner.py

From 20aab11 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 26 Jul 2019 13:45:09 +0200
Subject: [PATCH] [Tests] Do not fail when warnings are written to stderr

    print stderr with the test result instead

From c9a2cc3 Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 13 Jul 2019 18:41:03 -0400
Subject: [PATCH] Trivial: typo fixes

From 639b43d Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 20 Jul 2019 19:45:06 -0400
Subject: [PATCH] [Trivial] Spelling - Wither -> Whether

From 139d333 Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sun, 14 Jul 2019 20:26:13 -0400
Subject: [PATCH] Minting: Prevent potential negative out values

From 12c44ca Mon Sep 17 00:00:00 2001
From: furszy <matiasfurszyfer@protonmail.com>
Date: Thu, 1 Aug 2019 09:15:40 -0300
Subject: [PATCH] [Wallet][xION] zc public spend parse crash in wallet startup
 fixed.

From 983d97a Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 13 Jul 2019 17:39:58 -0400
Subject: [PATCH] [Refactor] Combine parameter checking of budget commands

From 421956f Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 2 Aug 2019 05:18:20 +0200
Subject: [PATCH] [Tests] Add Spork functional test and update RegTest spork
 key

From db702dc Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Fri, 2 Aug 2019 12:17:54 +0200
Subject: [PATCH] [Tests] Enable Spork messages on RegTest net

From f7ac53b Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sat, 27 Jul 2019 13:36:55 -0400
Subject: [PATCH] [RPC] Correct issues with budget commands

From 7261134 Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Thu, 1 Aug 2019 21:52:28 -0400
Subject: [PATCH] [Review] Convert runtime_error to JSONRPCError

From 2eacdb7 Mon Sep 17 00:00:00 2001
From: random-zebra <random.zebra@protonmail.com>
Date: Tue, 6 Aug 2019 21:03:58 +0200
Subject: [PATCH] [Refactor] Fix stake age checks for regtest

    - fix age check in CheckProofOfStake
    - move nStakeMinAge to chain params
    - fix error logs in kernel.cpp

From b7a9a9c Mon Sep 17 00:00:00 2001
From: Cave Spectre <crypto@pontificatingnobody.com>
Date: Sun, 21 Jul 2019 16:00:25 -0400
Subject: [PATCH] [Staking] Modify miner and staking thread for efficency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Warrows Warrows

Labels
Bug GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Wallet] Remove (explicitely) unused tx comparator Warrows/PIVX
4 participants
@Warrows @DSofter @mhannigan @Fuzzbawls