[Wallet] Remove (explicitely) unused tx comparator #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
approved these changes
Jul 10, 2019
We remove the '==' and '!=' operators from CMutableTransaction. These comparators are never explicitely used in our code. As it turns out, it was used implicitely and created this situation: PIVX-Project#510 So this change fixes PIVX-Project#510.
|
Rebased without change (to pass travis after #943 being merged). |
Fuzzbawls
approved these changes
Jul 24, 2019
Fuzzbawls
added a commit
that referenced
this pull request
Jul 28, 2019
3da857b [Wallet] Remove (explicitely) unused tx comparator (warrows) Pull request description: '==' and '!=' operators in CMutableTransaction are never used explicitly. Them being used implicitly is probably what causes #510. There is no good reason to keep them and BTC removed them here: bitcoin#13443 Should fix #510 ACKs for top commit: Fuzzbawls: ACK 3da857b Tree-SHA512: f5874d794b0a43b1290c977b10d16b1a8078b09862886f34bcdcc65e5a1ef2b9eb1c3e43dfe4711861609cf5a6c92d35180e37a95f5d5afcbac16854d5189dee
lyricidal
added a commit
to TheArcadiaGroup/DAPS
that referenced
this pull request
Oct 10, 2019
We remove the '==' and '!=' operators from CMutableTransaction. These comparators are never explicitely used in our code. PIVX-Project/PIVX#939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'==' and '!=' operators in CMutableTransaction are never used explicitly.
Them being used implicitly is probably what causes #510. There is no good reason to keep them and BTC removed them here: bitcoin#13443
Should fix #510