Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Remove (explicitely) unused tx comparator #939

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Warrows
Copy link
Collaborator

commented Jul 2, 2019

'==' and '!=' operators in CMutableTransaction are never used explicitly.
Them being used implicitly is probably what causes #510. There is no good reason to keep them and BTC removed them here: bitcoin#13443
Should fix #510

@Warrows Warrows self-assigned this Jul 2, 2019

@random-zebra
Copy link
Collaborator

left a comment

utACK 1f224d3

@furszy furszy self-requested a review Jul 10, 2019

@furszy

furszy approved these changes Jul 10, 2019

Copy link
Collaborator

left a comment

utACK 1f224d3

[Wallet] Remove (explicitely) unused tx comparator
We remove the '==' and '!=' operators from CMutableTransaction.
These comparators are never explicitely used in our code.
As it turns out, it was used implicitely and created this situation:
#510
So this change fixes #510.

@Warrows Warrows force-pushed the Warrows:2019_fix_510 branch from 1f224d3 to 3da857b Jul 11, 2019

@Warrows

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

Rebased without change (to pass travis after #943 being merged).

@Warrows Warrows added this to the 4.0.0 milestone Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.