[Backport] 5.3.1 backports #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directory is automatically created by the build process (in the build target directory, see bitcoin#16588) and doesn't need to be in the repository nor in the tarballs. Move associated ignore directive to top-level `.gitignore` file. Github-Pull: bitcoin#2525 Rebased-From: 4a18d50
The build date does only makes sense for custom/self-compiled PIVX-core versions because we are using static build-dates for our deterministic release builds. Coming from btc@4856f1d6712cdb2eac8712e379fd1e351583d78f Github-Pull: bitcoin#2525 Rebased-From: b22dc99
Putting the build date in the executable is a practice that has no place in these days, now that deterministic building is increasingly common. Continues bitcoin#7732 which did this for the GUI. Github-Pull: bitcoin#2525 Rebased-From: 55ec1ee
Github-Pull: bitcoin#2530 Rebased-From: f0fd8ac
Missing first argument (bolean, required, "enable"). Github-Pull: bitcoin#2540 Rebased-From: 4002ec9
Replace the string literal "PIVX Core" with the `PACKAGE_NAME` macro where appropriate and don't pass the macro to translation. Github-Pull: bitcoin#2491 Rebased-From: 03a002a
Github-Pull: bitcoin#2491 Rebased-From: 00dcec7
Many options are highly technical and refer internals, making it difficult to translate effectively. This can lead to translation errors that only add confusion, which is the opposite of what translation is intended to achieve. Further, these translations only ever worked for pivx-qt, as the console programs have no translation backend. Github-Pull: bitcoin#2491 Rebased-From: 8608d3a
The previous commits result in ~190 strings being removed for translation, with most of these strings having never been shown to end users in the past. Github-Pull: bitcoin#2491 Rebased-From: 7f655de
Github-Pull: bitcoin#2491 Rebased-From: d510ce0
the manpages for the master branch aren't typically updated, but the previous commit changed the format, so the manpage files in master should be updated to reflect that change. Github-Pull: bitcoin#2491 Rebased-From: d838f20
Github-Pull: bitcoin#2541 Rebased-From: 5eb2083
bitcoin#2525 introduced changes to the genbuild.sh script, which gets patched during the nightly snap builds. This follows up bitcoin#2525 to create a new, compatible patch. Github-Pull: bitcoin#2546 Rebased-From: 0f88891
Github-Pull: bitcoin#2553 Rebased-From: 5849e3e
Github-Pull: bitcoin#2557 Rebased-From: efddb3b
the current asset should be checked, not the "next" one. Github-Pull: bitcoin#2559 Rebased-From: db36fb8
This bug is caused by the fact that, if at startup the wallet has more than 4000 (SINGLE_THREAD_MAX_TXES_SIZE) transaction records, then chachedWallet is loaded not properly ordered, therfore the binary search (used later in updateWallet, to check whether a tx is already in the model) is unreliable. When the wallet has more than 4000 records, in fact, the list of records in TransactionTablePriv::refreshWallet() is split in batches, each one processed in a separate thread, processing the last batch in the main thread at the beginning, thus without preserving the original order (by hash) of walletTxes. Further, if the wallet has more than 200k records (MAX_AMOUNT_LOADED_RECORDS), then the list is also sorted by date before being trimmed and split in batches. Fix this by re-sorting the cachedWallet list by hash at the end of the multi-threaded update. x Github-Pull: bitcoin#2551 Rebased-From: 7562b63
…ed if the messages are broadcast. e.g: do not mark them as fulfilled before fail for a timeout. Github-Pull: bitcoin#2560 Rebased-From: 88704c4
Github-Pull: bitcoin#2562 Rebased-From: e8fddd7
As the transparent addr contacts are only being taken into account, the list is not being presented if the wallet only has shield and/or cold staking addr contacts. Github-Pull: bitcoin#2555 Rebased-From: 3be1a9d
Github-Pull: bitcoin#2555 Rebased-From: 23af3d9
Plus delete AddNewContactDialog dialog after use it. Github-Pull: bitcoin#2555 Rebased-From: c5e81a1
|
Updated with merged PRs, ready to go. |
Fuzzbawls
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs List:
Open PRs that have to get merged to be added here: