[Build] Get rid of CLIENT_DATE #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directory is automatically created by the build process (in the build target directory, see bitcoin#16588) and doesn't need to be in the repository nor in the tarballs. Move associated ignore directive to top-level `.gitignore` file.
The build date does only makes sense for custom/self-compiled PIVX-core versions because we are using static build-dates for our deterministic release builds. Coming from btc@4856f1d6712cdb2eac8712e379fd1e351583d78f
Putting the build date in the executable is a practice that has no place in these days, now that deterministic building is increasingly common. Continues bitcoin#7732 which did this for the GUI.
Fuzzbawls
approved these changes
Sep 2, 2021
Fuzzbawls
added a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Sep 10, 2021
PIVX-Project#2525 introduced changes to the genbuild.sh script, which gets patched during the nightly snap builds. This follows up PIVX-Project#2525 to create a new, compatible patch.
furszy
added a commit
that referenced
this pull request
Sep 10, 2021
0f88891 [Snap] Fix nightly build's genbuild.sh patch (Fuzzbawls) Pull request description: #2525 introduced changes to the genbuild.sh script, which gets patched during the nightly snap builds. This follows up #2525 to create a new, compatible patch. ACKs for top commit: random-zebra: utACK 0f88891 furszy: utACK 0f88891 Tree-SHA512: f09ea92a00baf3fb4f6089659350703979b4da86daad5cd8942ae54e0f802b4c7a2ffe6a3f5a5722974f27b4e62b5c7d320a7e6a554ebecb8780446c1ae026ac
furszy
referenced
this pull request
in furszy/bitcoin-core
Sep 17, 2021
This directory is automatically created by the build process (in the build target directory, see bitcoin#16588) and doesn't need to be in the repository nor in the tarballs. Move associated ignore directive to top-level `.gitignore` file. Github-Pull: bitcoin#2525 Rebased-From: 4a18d50
furszy
referenced
this pull request
in furszy/bitcoin-core
Sep 17, 2021
The build date does only makes sense for custom/self-compiled PIVX-core versions because we are using static build-dates for our deterministic release builds. Coming from btc@4856f1d6712cdb2eac8712e379fd1e351583d78f Github-Pull: bitcoin#2525 Rebased-From: b22dc99
furszy
referenced
this pull request
in furszy/bitcoin-core
Sep 17, 2021
Putting the build date in the executable is a practice that has no place in these days, now that deterministic building is increasingly common. Continues bitcoin#7732 which did this for the GUI. Github-Pull: bitcoin#2525 Rebased-From: 55ec1ee
furszy
referenced
this pull request
in furszy/bitcoin-core
Sep 17, 2021
bitcoin#2525 introduced changes to the genbuild.sh script, which gets patched during the nightly snap builds. This follows up bitcoin#2525 to create a new, compatible patch. Github-Pull: bitcoin#2546 Rebased-From: 0f88891
furszy
referenced
this pull request
in furszy/bitcoin-core
Sep 19, 2021
This directory is automatically created by the build process (in the build target directory, see bitcoin#16588) and doesn't need to be in the repository nor in the tarballs. Move associated ignore directive to top-level `.gitignore` file. Github-Pull: bitcoin#2525 Rebased-From: 4a18d50
furszy
referenced
this pull request
in furszy/bitcoin-core
Sep 19, 2021
The build date does only makes sense for custom/self-compiled PIVX-core versions because we are using static build-dates for our deterministic release builds. Coming from btc@4856f1d6712cdb2eac8712e379fd1e351583d78f Github-Pull: bitcoin#2525 Rebased-From: b22dc99
furszy
referenced
this pull request
in furszy/bitcoin-core
Sep 19, 2021
Putting the build date in the executable is a practice that has no place in these days, now that deterministic building is increasingly common. Continues bitcoin#7732 which did this for the GUI. Github-Pull: bitcoin#2525 Rebased-From: 55ec1ee
furszy
referenced
this pull request
in furszy/bitcoin-core
Sep 19, 2021
bitcoin#2525 introduced changes to the genbuild.sh script, which gets patched during the nightly snap builds. This follows up bitcoin#2525 to create a new, compatible patch. Github-Pull: bitcoin#2546 Rebased-From: 0f88891
Fuzzbawls
added a commit
that referenced
this pull request
Sep 21, 2021
2981a17 GUI: Remove unused, and invalid, cached QR pixmap pointer. (furszy) 798c3e9 GUI: addresses widget files overall code cleanup. (furszy) 51f6555 GUI: fix contacts list not being shown. (furszy) 5be181a [Consensus] Add checkpoints before v5.3.1 release Github-Pull: #2562 Rebased-From: e8fddd7 (random-zebra) 17fa0eb Masternode-sync: Only mark tier two messages sync requests as fulfilled if the messages are broadcast. e.g: do not mark them as fulfilled before fail for a timeout. (furszy) 2f98acf [BUG][GUI] Fix random double/triple transaction record issue (random-zebra) 754177e [BUG][TierTwo] Clear fulfilled requests when mnsync fails (random-zebra) 5a2e0d1 [Trivial] Update labelSubtitleAddress text in send widget ui Github-Pull: #2557 Rebased-From: efddb3b (random-zebra) 09b8ec0 [BUG] Spork signer doesn't persist new spork value to DB Github-Pull: #2553 Rebased-From: 5849e3e (random-zebra) 7f827e9 [Snap] Fix nightly build's genbuild.sh patch (Fuzzbawls) 24a1407 [Gitian] Ignore changes to relic_conf.h.in (Fuzzbawls) b400640 Update manpages to reflect newer template (Fuzzbawls) ecdbf86 [Docs] Reformat -help output for help2man (Fuzzbawls) 656be59 Run make translate to update source files (Fuzzbawls) cd8d0b5 Stop translating command line options (Fuzzbawls) 004efe9 Stop translating remaining usages of PACKAGE_NAME (Fuzzbawls) 67e7938 Unify product name to as few places as possible (Fuzzbawls) 4fe9030 [RPC][Doc] Fix RPC/cli example in setautocombinethreshold help (random-zebra) 5f9aac4 Refactor: remove duplicated coll. confirmation check in MNModel::data Github-Pull: #2530 Rebased-From: f0fd8ac (random-zebra) 2a947c0 build: Get rid of `CLIENT_DATE` (Wladimir J. van der Laan) 51fca36 [Qt] Debug window: remove "Build date". (furszy) d223d90 build: Remove src/obj directory from repository (Wladimir J. van der Laan) Pull request description: PRs List: * #2525. * #2530. * #2540. * #2491. * #2541. * #2546. * #2553. * #2557. * #2559. Open PRs that have to get merged to be added here: * * [x] #2560. * * [x] #2555. * * [x] #2551. * * [x] #2562. ACKs for top commit: random-zebra: ACK 2981a17 Fuzzbawls: ACK 2981a17 Tree-SHA512: 400c6cd5c05c99b79c67cb0158048315f33d18a49c9606ad668727b6534c84bbbc8617eb7759b9b6fb230f8fb8b94e74902d03e1579b23b3e84d063ec7a142fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back porting:
CLIENT_DATEbitcoin/bitcoin#8181.