-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async server #109
async server #109
Conversation
any news ? |
No, I've been busy with FOSDEM so I haven't had time to review this yet. |
anyone else can review ? I wanna finish my PRs during Spring Festival |
Unfortunately I'm the only one with the required amount of familiarity with the codebase. I unindented the |
anyway thanks, I will create rest of PRs soon. |
Please note that I added another commit to fix up some style things, so please rebase them on the current master :) |
It seems the test is not working from this PR, please fix it |
Addresses PMunch#109 (comment) Co-authored-by: PMunch <peterme@peterme.net>
Addresses #109 (comment) Co-authored-by: PMunch <peterme@peterme.net> Co-authored-by: PMunch <peterme@peterme.net>
Addresses PMunch#109 (comment) Co-authored-by: PMunch <peterme@peterme.net> Co-authored-by: PMunch <peterme@peterme.net>
hmm , as changed main branch github can't not really diff like other tools, please just check async part.