[WIP] Downsampling through robin_set #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make voxel computation consistent across all source code (PRBonn#354)
This reverts commit e5e146c.
behaviour to dont degraded the performences
tizianoGuadagnino
changed the title
|
The difference in performances between the two versions is nothing, and I feel the code for the random sampling + |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to maintain the classical behavior of our beloved
VoxelDownsamplewhile taking what is good from #347, a.k.a. avoiding the doubleforloop over the LiDAR frame and hash table.All the credit for this change goes to @l00p3. Once it is ready to merge (if), I will ensure you are between the contributors.
I will start the testing process today and come back to you, @nachovizzo @benemer feel free to be
-Wpedantic